Skip to content

fix: fix sha256_password to work correctly over a TLS connection #3809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wellwelwel merged 5 commits into from
Oct 3, 2025
Merged

fix: fix sha256_password to work correctly over a TLS connection #3809

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c7dc63d
fix: handle case with sha256_authentication over tls connection
viladimiru Sep 22, 2025
93ebb2c
fix: lint
viladimiru Sep 22, 2025
e3c4d9c
Merge branch 'master' into fix/sha256-password-auth-plugin
wellwelwel Sep 29, 2025
43ed3be
fix: ensure tls over the stream instance
viladimiru Oct 3, 2025
5654ffc
fix: variable name
viladimiru Oct 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions lib/auth_plugins/sha256_password.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
const PLUGIN_NAME = 'sha256_password';
const crypto = require('crypto');
const { xorRotating } = require('../auth_41');
const Tls = require('tls');

const REQUEST_SERVER_KEY_PACKET = Buffer.from([1]);

Expand Down Expand Up @@ -32,6 +33,14 @@ module.exports =
return (data) => {
switch (state) {
case STATE_INITIAL:
if (
connection.stream instanceof Tls.TLSSocket &&
connection.stream.encrypted === true
) {
// We don't need to encrypt passwords over TLS connection
return Buffer.from(`${password}\0`, 'utf8');
}

scramble = data.slice(0, 20);
// if client provides key we can save one extra roundrip on first connection
if (pluginOptions.serverPublicKey) {
Expand Down