digitally sign Windows downloads of talosctl

[brantgurga]

Feature Request

digitally sign the talosctl executable for Windows to help build reputation so SmartScreen and similar download screening can build reputation around a SideroLabs signing certificate instead of the current state of treating the downloads independently which means new version have no reputation and get treated as suspicious and made hard to download in browser.

Description

Frequently talosctl downloads will trigger initial SmartScreen blocking.

Omnictl has similar issues and a feature request was opened for it as well.

[rothgar]

We plan on doing this at some point as we're getting the chocolaty repo transferred to siderolabs so we can properly release it in that repo.

A helpful walkthrough on how we can do it with GitHub CI

https://federicoterzi.com/blog/automatic-codesigning-on-windows-using-github-actions/

[brantgurga]

@rothgar I got properties added to the omnictl Windows binary with the bulk of the change in Dockerfile. Since Dockerfile is generated though, I need to figure out the kres stuff and figure out where/how to adjust that. I'm sure similar adjustment would be needed for the signing too. That's in pull request draft siderolabs/omni#667

[github-actions]

This issue is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.

[brantgurga]

Still applicable.

[github-actions]

This issue is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.

[brantgurga]

Still applicable.