fix: ignore errors on duplicate SetHeader calls
#11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating gRPC library to 1.47 version makes it more picky about the duplicate calls to `SetHeader`. Due to the nature of proxying, we might try to set it multiple times, so simply ignore the error (doing best effort to set it correctly, but with multiple upstreams setting headers from all upstreams is not possible). Signed-off-by: Andrey Smirnov <[email protected]>
smira
commented
Jun 6, 2022
| return fmt.Errorf("error setting headers from client %s: %w", src.backend, err) | ||
| } | ||
|
|
||
| dst.SetHeader(md) //nolint:errcheck // ignore errors, as we might try to set headers multiple times |
Member
Author
There was a problem hiding this comment.
this is the actual change, everything else is just unrelated Kres updates/linting fixes ❗
Unix4ever
approved these changes
Jun 6, 2022
Member
Author
|
/m |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating gRPC library to 1.47 version makes it more picky about the
duplicate calls to
SetHeader. Due to the nature of proxying, we mighttry to set it multiple times, so simply ignore the error (doing best
effort to set it correctly, but with multiple upstreams setting headers
from all upstreams is not possible).
Signed-off-by: Andrey Smirnov [email protected]