Skip to content

Conversation

@DmitriyMV
Copy link

  • run rekres
  • github.com/Masterminds/sprig/v3 to v3.3.0
  • github.com/google/go-github to v65.0.0
  • github.com/moby/buildkit to v0.16.0
  • golang.org/x/oauth2 to v0.23.0

- run rekres
- github.com/Masterminds/sprig/v3 to v3.3.0
- github.com/google/go-github to v65.0.0
- github.com/moby/buildkit to v0.16.0
- golang.org/x/oauth2 to v0.23.0

Signed-off-by: Dmitriy Matrenichev <[email protected]>
Copy link
Member

@smira smira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't there's any real need to bump anything here?

@DmitriyMV
Copy link
Author

@smira rekres brings most of the stuff, including bumps to tools and Go (from 1.22 to 1.23).

@smira
Copy link
Member

smira commented Oct 2, 2024

@smira rekres brings most of the stuff, including bumps to tools and Go (from 1.22 to 1.23).

I understand that, but why? Is there a known issue? Update would make it better in some way? Fix some bug?

@DmitriyMV
Copy link
Author

@smira rekres brings most of the stuff, including bumps to tools and Go (from 1.22 to 1.23).

I understand that, but why? Is there a known issue? Update would make it better in some way? Fix some bug?

As for using facing changes, no I don't think so. Internally binary will probably work a little bit better, but other than that, no, probably not.

We can merge this, but do not bump the resulting commit until we get changes that are actually user visible.

@smira
Copy link
Member

smira commented Oct 2, 2024

I'm not opposed to this PR in particular, but I might see it being a bit of an effort we could skip, as bumping bldr version across our fleet is also a long way to go. So I'd rather bump as we make actual changes to bldr, so that bumping bldr at least provides are some fixes/changes.

@smira
Copy link
Member

smira commented Oct 7, 2024

@DmitriyMV let's merge this?

@DmitriyMV
Copy link
Author

/m

@talos-bot talos-bot merged commit 73fad60 into siderolabs:main Oct 7, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants