fix: restore error bubbling behavior from v1.0.0 #1048
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace FetchConfigurationError throwing with Promise-based error bubbling - Add cookie handling to .then() chain for successful responses only - Preserve v1.0.0 behavior where HTTP errors reach caller unchanged - Fix authentication error handling regression from v1.0.1 Allows .catch((error) => error.data) pattern to work correctly again for normal HTTP error responses like 401 authentication failures.
commit: |
phoenix-ru
approved these changes
Aug 14, 2025
Collaborator
phoenix-ru
left a comment
phoenix-ru
left a comment
There was a problem hiding this comment.
Hi @lendenmc, thank you for a great catch and amazing work with the PR (special thanks for 3 reproduction links!). I tested with the version released by a bot and it does in fact fix the issue 🚀
Contributor
|
Thanks @lendenmc for the great contribution (: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows .catch((error) => error.data) pattern to work correctly again for normal HTTP error responses like 401 authentication failures.
🔗 Linked issue
Fixes #1047
❓ Type of change
📚 Description
This PR fixes the authentication error handling regression introduced in v1.0.1 where
signIn('credentials', {...})throws "TypeError: Cannot read properties of undefined (reading 'url')" instead of returning proper error responses.Root Cause:
The change from
return $fetch(joinedPath, fetchOptions)toawait $fetch.raw(joinedPath, fetchOptions)in v1.0.1 caused HTTP errors to be caught and wrapped inFetchConfigurationError, losing the original error data.Solution:
Replace the await/try-catch pattern with a Promise chain approach that:
.then()chainImpact:
Restores fine-grained authentication error handling for credentials authentication while preserving the v1.0.1 cookie functionality.
📝 Checklist