Skip to content

Conversation

@Twixes
Copy link
Contributor

@Twixes Twixes commented Jan 11, 2022

I'm keen on using cobe in my personal project, but I despise JavaScript – TypeScript is the way to go. Unfortunately I haven't found type definitions for cobe so I made them myself and I'm happy to contribute them, so that other TypeScript projects can use this globe too!

@Twixes
Copy link
Contributor Author

Twixes commented Jan 11, 2022

An alternative that may also we worth considering is just adding the definitions to the code itself (basically just changing .js to .ts). Opted for .d.ts just because that's not invasive.

@JuandaGarcia
Copy link

I hope he accepts this pull request, I also want to use it with typescript projects.

@shuding shuding merged commit 891b78b into shuding:main Mar 23, 2022
@shuding
Copy link
Owner

shuding commented Mar 23, 2022

Thanks for adding these type definitions!

@Twixes Twixes deleted the typescript branch June 11, 2022 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants