Core path update #49
Merged
Core path update #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 17, 2020 14:14
|
Hi. Thank you for your contribution. I'm at work right now, but I'll check and release the update today. |
avdeev
approved these changes
Apr 17, 2020
mrdimidium
requested changes
Apr 17, 2020
There was a problem hiding this comment.
Updating the path in the template is not enough. You need to update the regex in build script.
This is it:
Line 32 in 7b9b04b
If you don't want to get into the code, I can finish it myself tonight.
Contributor
Author
Huh, too late. Done :) |
|
Oh, and the filename too, please :) Line 37 in 7b9b04b |
Contributor
Author
|
Done. It kinda makes you understand that it’s a bit too much hard-coded ;) |
|
Yes, I agree that it is worth making this dependency more flexible. |
mrdimidium
approved these changes
Apr 17, 2020
|
I published version 0.3.0 in npm, with your PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@shower/core is now released as v3.0.0 stable, so I’m currently moving the rest of the packages to the
@showerorganization. To publish the@shower/showerpackage I need to update the cli with the new core path first.Would you mind checking my changes and releasing the new cli version? :)