feat: shorebird flutter should work without setting FLUTTER_STORAGE_BASE_URL #97
Conversation
|
files-changed.yml was failing for us (due to us not producing an engine build for every flutter commit yet), and since we're not using it for anything I've removed it. Most of this change was simply fixing the flutter_tools tests to run correctly. |
|
I suspect not all of the places I changed googlestorage to download.shorebird.dev were necessary, but I don't think any of them hurt? |
|
OK, going to yolo this in @bryanoltman, happy to make any changes you might suggest in post. |
There was a problem hiding this comment.
This seems fine, but curious why it's necessary as part of a PR to remove the need to set FLUTTER_STORAGE_BASE_URL
There was a problem hiding this comment.
It was originally to try and fix /bin/dart usage, I believe the tests also depend on it. It's possible I could have separated that out after I removed detect_changes.yml
…ASE_URL (#97) * fix: make dart/flutter work without FLUTTER_STORAGE_BASE_URL * feat: shorebird flutter should work without setting FLUTTER_STORAGE_BASE_URL * fix: flutter_tools test fixes * fix: enable running flutter_tools tests * chore: remove unnecessary workflow
…ASE_URL (#97) * fix: make dart/flutter work without FLUTTER_STORAGE_BASE_URL * feat: shorebird flutter should work without setting FLUTTER_STORAGE_BASE_URL * fix: flutter_tools test fixes * fix: enable running flutter_tools tests * chore: remove unnecessary workflow
This replaces many, but not all, uses of storage.googleapis.com with download.shorebird.dev, which should allow
flutteranddartwithin Shorebird's flutter fork to work without setting FLUTTER_STORAGE_BASE_URL. Which should allow us to run upstream tests.Fixing shorebirdtech/shorebird#2392.