Skip to content

test: Add comprehensive tests for Docker/Compose parser (91.5% coverage) #425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shivasurya merged 1 commit into from
Dec 9, 2025
Merged

test: Add comprehensive tests for Docker/Compose parser (91.5% coverage) #425

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions sast-engine/graph/parser_docker.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,15 +147,15 @@ func parseDockerCompose(filePath string, graph *CodeGraph) error {

// Convert each service to a CodeGraph node
for serviceName, serviceNode := range composeGraph.Services {
node := convertComposeServiceToNode(serviceName, serviceNode, filePath, composeGraph)
node := convertComposeServiceToNode(serviceName, serviceNode, filePath)
graph.AddNode(node)
}

return nil
}

// convertComposeServiceToNode converts a docker-compose service to a CodeGraph Node.
func convertComposeServiceToNode(serviceName string, serviceNode *YAMLNode, filePath string, composeGraph *ComposeGraph) *Node {
func convertComposeServiceToNode(serviceName string, serviceNode *YAMLNode, filePath string) *Node {
// Generate unique ID with line number (YAML doesn't provide column, default to 1)
// For YAML, we don't have exact line numbers from the parser, so we use a hash
// Format: "compose:<file>:<service>"
Expand All @@ -177,13 +177,13 @@ func convertComposeServiceToNode(serviceName string, serviceNode *YAMLNode, file

// Extract service properties and store in MethodArgumentsValue
// This allows DSL rules to query service configuration
node.MethodArgumentsValue = extractComposeServiceProperties(serviceName, serviceNode, composeGraph)
node.MethodArgumentsValue = extractComposeServiceProperties(serviceNode)

return node
}

// extractComposeServiceProperties extracts properties from a docker-compose service.
func extractComposeServiceProperties(serviceName string, serviceNode *YAMLNode, composeGraph *ComposeGraph) []string {
func extractComposeServiceProperties(serviceNode *YAMLNode) []string {
props := []string{}

// Extract common security-relevant properties
Expand Down
Loading
Loading