Skip to content

Conversation

@shivasurya
Copy link
Owner

Problem

The R2 upload workflow is failing with:

ERROR: Unexpected module failures: msilib, nis

Root Cause

The stdlib generator only allowed Windows-specific modules (msvcrt, nt, winreg, winsound, _winapi) to fail, but didn't include:

  • msilib: Windows-only Microsoft Installer library
  • nis: Unix Network Information Service (not available on all Linux systems, including GitHub Actions runners)

Solution

Add these modules to the platform-specific allowlist so they don't cause generation failures.

Testing

After merge, the workflow should complete successfully and upload to R2.

- msilib: Windows-only (Microsoft Installer library)
- nis: Unix Network Information Service (not available on all systems)

These platform-specific modules should not cause generation failures.
@safedep
Copy link

safedep bot commented Nov 28, 2025

SafeDep Report Summary

Green Malicious Packages Badge Green Vulnerable Packages Badge Green Risky License Badge

No dependency changes detected. Nothing to scan.

This report is generated by SafeDep Github App

@shivasurya shivasurya merged commit 6db32c4 into main Nov 28, 2025
3 checks passed
@shivasurya shivasurya deleted the fix/stdlib-platform-modules branch November 28, 2025 20:40
@shivasurya shivasurya self-assigned this Nov 28, 2025
@codecov
Copy link

codecov bot commented Nov 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.27%. Comparing base (9f531d7) to head (18e5c76).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #409   +/-   ##
=======================================
  Coverage   80.27%   80.27%           
=======================================
  Files          77       77           
  Lines        7763     7763           
=======================================
  Hits         6232     6232           
  Misses       1289     1289           
  Partials      242      242           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants