fix: Allow msilib and nis modules to fail gracefully #409
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The R2 upload workflow is failing with:
Root Cause
The stdlib generator only allowed Windows-specific modules (
msvcrt,nt,winreg,winsound,_winapi) to fail, but didn't include:msilib: Windows-only Microsoft Installer librarynis: Unix Network Information Service (not available on all Linux systems, including GitHub Actions runners)Solution
Add these modules to the platform-specific allowlist so they don't cause generation failures.
Testing
After merge, the workflow should complete successfully and upload to R2.