fix: Remove AWS credentials action, install AWS CLI directly for R2 #408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The aws-actions/configure-aws-credentials action doesn't work with Cloudflare R2 as it tries to use AWS STS. Instead, install AWS CLI directly and use environment variables for R2 credentials.
SafeDep Report Summary
No dependency changes detected. Nothing to scan. This report is generated by SafeDep Github App |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The R2 upload workflow was failing with:
Root Cause
The
aws-actions/configure-aws-credentials@v4action is designed for AWS and tries to use AWS STS (Security Token Service) which doesn't exist for Cloudflare R2.Solution
Testing
After merge, we can manually trigger the workflow to test the R2 upload.
Files Changed
.github/workflows/stdlib-r2-upload.yml