Use Go 1.23 everywhere

[SaschaSchwarze0]

Changes

Go 1.24 is expected to be shipped in February. Then, 1.22 will be EOS. Now is therefore a good time to start building with Go 1.23.

Submitter Checklist

• Includes tests if functionality changed/was added
• Includes docs if changes are user-facing
• Set a kind label on this PR
• Release notes block has been filled in, or marked NONE

Release Notes

All binaries are now compiled with Go 1.23

[apoorvajagtap]

Quick question, are we planning to bump the version in go.mod separately? Might help to bump that too in the same PR.

[SaschaSchwarze0]

Quick question, are we planning to bump the version in go.mod separately? Might help to bump that too in the same PR.

No, I stop go.mod bumping. The go.mod defines which version is necessary to compile and should be based on which Go language capabilities are used. By using a newer compiler, we have not started using Go 1.23 language feature which means that we can keep go.mod untouched so that people who still want (or have to) compile with Go 1.22 will still be happy. Having said that, it will anyway be bumped by our dependencies either using Go 1.23 language features or by incorrectly declaring what they need. This will already be the case with #1777.

[apoorvajagtap]

No, I stop go.mod bumping. The go.mod defines which version is necessary to compile and should be based on which Go language capabilities are used. By using a newer compiler, we have not started using Go 1.23 language feature which means that we can keep go.mod untouched so that people who still want (or have to) compile with Go 1.22 will still be happy. Having said that, it will anyway be bumped by our dependencies either using Go 1.23 language features or by incorrectly declaring what they need. This will already be the case with #1777.

Got it. Thanks for sharing this!

[apoorvajagtap]

/lgtm

[apoorvajagtap]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: apoorvajagtap

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [apoorvajagtap]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment