Test connectivity to the Git or Registry host before accessing the source#1762
Merged
openshift-merge-bot[bot] merged 2 commits intoJan 7, 2025
Conversation
openshift-ci
Bot
added
the
release-note
pull-request-size
Bot
added
the
size/L
HeavyWombat
requested changes
Jan 4, 2025
HeavyWombat
left a comment
HeavyWombat
left a comment
Contributor
There was a problem hiding this comment.
Nice! Thanks for the PR. I just found some minor things, which I think should be addressed.
…urce This aims to mitigate rare failures where a BuildRun pod runs in a namespace with NetworkPolicies present. Kubernetes defines that isolation rules are guaranteed to be applied before any container of the Pod is started, but allow rules are eventually applied. Signed-off-by: Sascha Schwarze <schwarzs@de.ibm.com>
Co-authored-by: Matthias Diester <mddiester@gmail.com> Signed-off-by: Sascha Schwarze <schwarzs@de.ibm.com>
SaschaSchwarze0
force-pushed
the
sascha-test-connection
branch
from
f8676a1 to
48b2ed6
Compare
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: HeavyWombat The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This aims to mitigate rare failures where a BuildRun pod runs in a namespace with NetworkPolicies present. Kubernetes defines that isolation rules are guaranteed to be applied before any container of the Pod is started, but allow rules are eventually applied. See https://kubernetes.io/docs/concepts/services-networking/network-policies/#pod-lifecycle: Therefore, pods must be resilient against being started up with different network connectivity than expected
I am therefore extending the logic of the Git and OCI artifact source steps to test connectivity as these are the first containers in a BuildRun pod that actually require network connectivity. And given we own them, we should be resilient.
Submitter Checklist
Release Notes