Extend Dockerfile based build strategies with target build stage#1737
Conversation
|
very interesting, can you reference https://docs.docker.com/build/building/multi-stage/#stop-at-a-specific-build-stage in the above PR description. What are the use cases on this for SHP users? |
The Dockerfile that I had stumbled over this is https://github.com/ONLYOFFICE/Docker-Docs/blob/v8.2.1-1/Dockerfile. It is a single Dockerfile that you must run for targets like proxy, converter or docservice to produce the different images you need for onlyoffice. |
Signed-off-by: Sascha Schwarze <[email protected]>
a0da3ca to
f4f5470
Compare
|
Added e2e test cases. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qu1queee The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
I recently stumbled over a single Dockerfile that combined multiple output images and one had to run
docker build --target STAGEto select which one should actually be built. And that was not possible with our sample build strategies because we had no parameter for the target stage. Adding this. Related Dockerfile feature: https://docs.docker.com/build/building/multi-stage/#stop-at-a-specific-build-stageSubmitter Checklist
Release Notes