fix(twoslash): forward tsModule to createTwoslasher#1271
Merged
Conversation
✅ Deploy Preview for shiki-matsu ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for shiki-next ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1271 +/- ##
==========================================
+ Coverage 89.66% 89.67% +0.01%
==========================================
Files 79 79
Lines 3512 3516 +4
Branches 1007 1011 +4
==========================================
+ Hits 3149 3153 +4
Misses 327 327
Partials 36 36 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
antfu
changed the title
tsModule to createTwoslashertsModule to createTwoslasher
Contributor
Author
|
Hey @antfu, could you release a new version with this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I did not use AI to write this PR. Opening the PR just now because when I found/fixed the issue, external contributions were disabled.
I ran into an issue while building the new https://html.kitajs.org/ docs. I wanted code blocks to render warnings from @kitajs/ts-html-plugin, a custom tsserver plugin that adds extra diagnostics over JSX syntax, but tsconfig's plugin option is a tsserver only thing, thus we need to extend twoslash's tsModule to simulate this behavior.
transformerTwoslash calls createTwoslasher once at startup and only passes cache to it. tsModule is a create-time option, so it has to be there at that point. passing it inside twoslashOptions is too late since it's only used per-block.