Skip to content

Fix: Prevent UnicodeDecodeError for usernames with accents #2739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: Prevent UnicodeDecodeError for usernames with accents #2739

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion sherlock_project/sherlock.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@

import requests
from requests_futures.sessions import FuturesSession
from urllib.parse import quote

from sherlock_project.__init__ import (
__longname__,
Expand Down Expand Up @@ -136,6 +137,10 @@ def get_response(request_future, error_type, social_network):
except requests.exceptions.RequestException as err:
error_context = "Unknown Error"
exception_text = str(err)
except UnicodeDecodeError as erru:
error_context = "Unicode Decode Error"
exception_text = str(erru)


return response, error_context, exception_text

Expand Down Expand Up @@ -243,7 +248,8 @@ def sherlock(
headers.update(net_info["headers"])

# URL of user on site (if it exists)
url = interpolate_string(net_info["url"], username.replace(' ', '%20'))
username_safe = quote(username)
url = interpolate_string(net_info["url"], username_safe)

# Don't make request if username is invalid for the site
regex_check = net_info.get("regexCheck")
Expand Down