chore: close issue #1618#3659
Closed
themanforfree wants to merge 1 commit into
Closed
Conversation
The issue sharkdp#1618 has been resolved by commit 12a2a45 in PR sharkdp#3457. The `--list-themes` command now correctly handles BAT_OPTS environment variables. Testing: - `BAT_OPTS="--paging=always" bat --list-themes` works correctly - All 28 themes are listed (not paginated one by one) - The fix was merged in commit 12a2a45 (PR sharkdp#3457)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR closes issue #1618.
Background
Issue #1618 reported that when
BAT_OPTSincludes--paging=always, the--list-themescommand would page through themes one at a time instead of listing all themes, making it unusable.Resolution
This issue has been resolved by commit 12a2a45 in PR #3457. The fix properly handles the
--list-themescommand withBAT_OPTSenvironment variables.Verification
Verified that the fix works correctly:
BAT_OPTS="--paging=always" bat --list-themesdisplays all 28 themesRelated Issues
--list-themespagination is broken #3455 and Automatically use pager on bat (--list-themes|-h|--help) #1587