--theme: return a list of all themes if the theme argument doesn't match
#3009
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monkeydom
changed the title
--theme: return a list of all themes if the themes argument doesn't match
monkeydom
changed the title
--theme: return a list of all themes if the themes argument doesn't match--theme: return a list of all themes if the theme argument doesn't match
Enselic
requested changes
Jul 14, 2025
Collaborator
Enselic
left a comment
Enselic
left a comment
There was a problem hiding this comment.
Can you add a test for this please? Or adjust the existing test if we have one
Enselic
added
the
waiting-on-author
Collaborator
|
On a second thought, this seems fine to merge without a test. It just needs a rebase. |
Collaborator
|
Closing for now to keep the PR inbox clean but of course feel free to reopen if work resumes. |
Author
|
There was no way to reopen for me, force push did not update this one either, so made a new one: Honestly, so much time has gone since the initial opening that I just overlooked the notifications. Rebased and added your desired test. (Also: the existing submodule setup makes rebasing and not messing up quite teadious. My git gui client 'fork' almost falls over itself all the time) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This turns:
[bat warning]: Unknown theme 'SolarizedDark', using default.Into a more actionable:
[bat warning]: Unknown theme 'SolarizedDark', using default. (Available themes: 1337, Coldark-Cold, Coldark-Dark, DarkNeon, Dracula, GitHub, Monokai Extended, Monokai Extended Bright, Monokai Extended Light, Monokai Extended Origin, Nord, OneHalfDark, OneHalfLight, Solarized (dark), Solarized (light), Sublime Snazzy, TwoDark, Visual Studio Dark+, ansi, base16, base16-256, gruvbox-dark, gruvbox-light, zenburn)Might be worth doing a fuzzy prefix match too maybe?