issue 2561, send all [bat error]s to stderr in default_error_handler

[deboard]

issue 2561, send all [bat error]s to stderr in default_error_handler match default.

[deboard]

So, here is my entry into the CHANGELOG.md:

• Send all bat error messages to stderr, see [bat error]: 'conf.d' is a directory. is written to STDOUT instead of STDERR #2561 (@deboard)

The check is failing... Any ideas?

[keith-hall]

The CI logs show:

Grepping for PR info

I'm guessing it wants the PR # instead of the issue # in the changelog entry. So try with #2827 instead of #2561.

[deboard]

Thanks, that was it. Good to know.

…

On Tue, Jan 2, 2024 at 11:52 PM Keith Hall ***@***.***> wrote: The CI logs show: Grepping for PR info I'm guessing it wants the PR # instead of the issue # in the changelog entry. So try with #2827 instead of #2561. — Reply to this email directly, view it on GitHub <#2827 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJU7E6STSRDDSXQTI6WLCDYMTPZVAVCNFSM6AAAAABBKUMSBSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZUHA2DMOJYG4> . You are receiving this because you were mentioned.Message ID: ***@***.***>

-- Thanks, John 321-356-2301

[deboard]

This issue appears to be tied to if "attached_to_pager" is set to true in the Controller, stdout gets passed to default_error_handler (in error.rs) if so. A good fix may be to just always write "[bat error] {error}" to stderr in in the default section of the match in default_error_handler (error.rs@70).

I have tried this. It fixes the problem and doesn't doesn't mess with the pager functionality.

If you currently run bat like "bat --pager=never /tmp 2> /tmp/bat.txt", it handels redirection correctly.

[sharkdp]

Can we please turn this into a Rust-based integration test. See tests/integration_tests.rs and search for .stderr to see some examples.

[deboard]

Will do.

[sharkdp]

This script is still here. Can it be removed?

[sharkdp]

What is this?

[sharkdp]

Please remove the empty lines

[chicks-net]

This looks so close to being ready. Was there any particular reason this was abandoned?

[deboard]

I'll take a new look at it. I can't remember. Was I waiting for a review? Not sure. I'll get back at it.

[Enselic]

Closing as inactive for now.