Conversation
…of IO circle detected error
|
I am not sure how to fix this failing action Error: With the provided path, there will be 1 file uploaded
Artifact name is valid!
Root directory input is valid!
Error: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow runHow to fix this? |
|
I think the CI failure will be fixed by #2811. |
Enselic
left a comment
Enselic
left a comment
There was a problem hiding this comment.
Thank you for taking the time to create a PR. I skimmed it over and have one initial question.
src/bin/bat/main.rs
Outdated
| input_names += ", "; | ||
| } | ||
| } | ||
| print!("\x1b]2;{}\x07", input_names); |
There was a problem hiding this comment.
Will this behave well in all major terminal emulators on all major OSes?
There was a problem hiding this comment.
I believe ANSI escape characters are standard across terminal emulators on different OSes, https://en.wikipedia.org/wiki/ANSI_escape_code#OSC_(Operating_System_Command)_sequences
I have updated the 2 in this line to 0 to match those docs
|
Thanks for the review! |
|
Thank you for your contribution. I would also be worried about portability of this specific ANSI escape code. If we can not test this across a wide range of terminal emulators at the moment, let's maybe make this opt-in at first? |
|
Yes, that makes sense. I'll update this pr to make this opt-in |
4 participants
This PR is to resolve issue #2783
This change sets the terminal title to the input file names when the pager is being used & --set-terminal-title flag is used, to make this feature opt in
Screen.Recording.2024-01-27.at.14.34.07.mov