Disable completion of cache subcommand#2399
Disable completion of cache subcommand#2399Enselic merged 3 commits intosharkdp:masterfrom cyqsimon:no-cache-completion
cache subcommand#2399Conversation
There was a problem hiding this comment.
I'm no shell completion expert, but these changes look reasonable to me. And I am strongly in favor of the what the PR wants to achieve.
I'll set this as Approved. I'll give some more time for people to look at this. If no more input comes in, I'll merge this.
I think it is better to merge it so that problems can be found, if any, rather than letting the PR sit untouched for much longer.
Ideally we would have regression tests for completion scripts, but life is not always ideal.
|
@cyqsimon Can you also add an entry to CHANGELOG.md please? |
|
I agree. Thank you @cyqsimon. I would appreciate if we could remove the code in question, instead of commenting it. We would still keep the comments explaining why we're not completing |
See #2085 (comment).
TLDR: autocompleting the
cachesubcommand causes usability issues. This PR disables it.I am not terribly familiar with completion scripts TBH. If you are more competent please help check my edits, thanks.