Improve Manpage.sublime-syntax, Fix #2353#2364
Merged
Enselic merged 2 commits intosharkdp:masterfrom Oct 17, 2022
Freed-Wu:man
Merged
Improve Manpage.sublime-syntax, Fix #2353#2364Enselic merged 2 commits intosharkdp:masterfrom Freed-Wu:man
Enselic merged 2 commits intosharkdp:masterfrom
Freed-Wu:man
Conversation
Collaborator
|
It would be great to add some "highlighted file" tests for this. Basically just putting |
Contributor
Author
Done. |
keith-hall
approved these changes
Oct 12, 2022
Collaborator
keith-hall
left a comment
There was a problem hiding this comment.
Looks good. You can also optionally update the changelog so others will know what you fixed :)
Contributor
Author
Fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It still exists many problems, such as
man fzfShould we highlight
+xbeforeor?Case-XXXshouldn't be highlighted, right?Wrong
N[,...].How to distinguish the following
-.s?