Include git hash in bat -V and bat --version output if present#1921
Merged
Enselic merged 1 commit intosharkdp:masterfrom Oct 24, 2021
Merged
Include git hash in bat -V and bat --version output if present#1921Enselic merged 1 commit intosharkdp:masterfrom
bat -V and bat --version output if present#1921Enselic merged 1 commit intosharkdp:masterfrom
Conversation
Enselic
commented
Oct 23, 2021
I had to use a `lazy_static` due to that the clap API that only accepts a reference to a version string. And, in our code, only a 'static reference to a version string. Code could probably be refactored to accept a "normal" reference, but that would be a major undertaking.
9cd790c to
93d80d3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had to use a
lazy_staticdue to the strange clap API that only accepts a reference to a version string. And, in our current code, only a 'static reference to a version string is accepted. Code could of course be refactored, but it would be way more messy.I have several binaries of
batlying around everywhere, and with this PR, I (and anyone else of course) can just dobat -Vto find out exactly what version of bat is at hand. Right now I have to dobat --diagnostics | head, which is too unergonomic for my taste.I could of course have a local script to avoid repetition, but who wants to local scripts for these kinds of things?
The output looks like this:
which is identical to the output format in
--diagnostic:If no git repo is available at build time, the output is the same as before: