sort the language listing #113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharkdp
reviewed
May 14, 2018
src/main.rs
Outdated
| if app.matches.is_present("list-languages") { | ||
| let languages = assets.syntax_set.syntaxes(); | ||
| let mut languages = assets.syntax_set.syntaxes().to_owned(); | ||
| languages.sort_by(|a, b| a.name.to_uppercase().cmp(&b.name.to_uppercase())); |
Owner
There was a problem hiding this comment.
Would sort_by_key work here?
Something like
languages.sort_by_key(|s| s.name.to_uppercase())
Contributor
Author
There was a problem hiding this comment.
Yep. And which one do you prefer? How about sort_by_cached_key? See rust-lang/rust#48639.
Owner
There was a problem hiding this comment.
I don't think we have to worry about performance here, so I would prefer sort_by_key, since it is easier to read, in my opinion (sort_by_cached_key is also fine, if it's already available in our minimum-required rustc version).
sharkdp
reviewed
May 14, 2018
| "tests/snapshots/sample.rs", | ||
| &format!("--style={}", style), | ||
| ]) | ||
| .args(&["tests/snapshots/sample.rs", &format!("--style={}", style)]) |
rleungx
force-pushed
the
sort-the-language-listing
branch
from
5f7a2ab to
c2df74b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #111.