Ada language syntax highlighting support

[wiremoons]

Syntax:
Support for the Ada programing language. More info on Ada if needed.

Guideline Criteria:

• Ada language on packagecontrol.io : note is the older Ada.tmLanguage format - so wont work directly. This has however been converted and imported into bat successfully as a new Ada.sublime-syntax file with only minor changes needed - see repo linked below.

Working Version

• See the GitHub repo here for more information: https://github.com/wiremoons/ada-sublime-syntax
• The actual required raw Ada.sublime-syntax file is here: https://raw.githubusercontent.com/wiremoons/ada-sublime-syntax/main/ada-sublime-syntax/Ada.sublime-syntax

While it works fine for me with my local bat installation - would it be possible to include the file in the next relase of bat so other can benefit too?

Thanks

Simon

[sharkdp]

Thank you for your request!

Whether or not we are going to include it in bat depends on the outcome of the discussion at #1262. I think we should clarify that first before including new syntaxes (with fewer than 10k downloads on pakagecontrol.io).

[sharkdp]

Happy to include this, if someone wants to send a PR. See https://github.com/sharkdp/bat/blob/master/doc/assets.md#adding-new-builtin-languages-for-syntax-highlighting for instructions.

[wiremoons]

Happy to include this, if someone wants to send a PR. See https://github.com/sharkdp/bat/blob/master/doc/assets.md#adding-new-builtin-languages-for-syntax-highlighting for instructions.

Thank you for now offering to accept a PR @sharkdp, and for providing the instructions. I dont have a Rust development environment that is needed to build the bat code as part of the PR submission process. I have however asked for some help from the wider Ada community - as I expect someone out there develops in both Rust and Ada, who would be kind enough to submit a PR, when they get some spare time. Hope that's ok - and you don't mind waiting for a PR to be submitted, and keeping this issue open for a little while longer.

Thanks

Simon

[dkm]

Hey @wiremoons , any news about that? If your files are still up to date, I'll be happy to help create the PR

[dkm]

So, I went ahead and created a PR. But few things:

• it does not qualify for the "More than 10,000 downloads at Package Control". The package on which this one is based has only 8K downloads
• I'm not sure the syntax has been modified to handle Ada 2022, so maybe this would need to be fixed.
• The test in the PR is simply me taking my latest Ada pet project, but probably not a very representative example.

Still, I'm interested to know if it has any chance of being merged even without the only criterion being null. I would understand if not, but then I can leave this as a fork until it has more users.

Thanks for the nice doc for new contributors!

[wiremoons]

Hey @wiremoons , any news about that? If your files are still up to date, I'll be happy to help create the PR

@dkm As far as I know they are - so you should be able to use them OK still.

[dkm]

Thanks @wiremoons , as you can see above, I went ahead and created the corresponding PR, but I'm not even sure it qualifies for merge, so I'm waiting for someone (@sharkdp ?) to reply to this before doing any more work on that...