Fix CD workflow and test infrastructure #260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem:
- Naver API 'count' param drifts daily (days since fixed date)
- KRX date params (strtDd, endDd, etc.) cause match failures
- 7 cassettes recorded with stale values → tests failed
Solution:
1. Custom VCR matchers ignore volatile date/count parameters
- uri_without_dates: strips IGNORED_DATE_KEYS from query
- form_body_matcher: order-insensitive, ignores date keys
- before_record_request: scrubs params before saving
2. Regenerated 7 time-sensitive cassettes with current baseline:
- market/stock_ohlcv_by_date_*
- index/portfolio_deposit_file_*
- etf/{ticker,etn_ticker,elw_ticker}_list
- fetch full git history & tags, add version verification
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #260 +/- ##
=========================================
Coverage ? 74.49%
=========================================
Files ? 32
Lines ? 1992
Branches ? 0
=========================================
Hits ? 1484
Misses ? 508
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
CD Workflow (
cd.yml)contents:read,packages:write)Test Infrastructure (
conftest.py)use_cassettefixture to properly usevcr_configparameterform_body_matcherto use strict equality instead of superset matchingPrerequisites
Ensure
PYPI_API_TOKENis configured in repository secrets.Testing
All existing tests pass with updated VCR configuration.