Skip to content

fix: Correct PyPI release workflow permissions and tag handling #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mr-yoo wants to merge 4 commits into from
Closed

fix: Correct PyPI release workflow permissions and tag handling #259

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7aca989
bugfix: handle time-sensitive VCR cassettes with custom matchers
mr-yoo Jan 25, 2026
ba7252b
bugfix: fix release version detection in cd process
mr-yoo Jan 25, 2026
7d3b2ae
Update tests/conftest.py
mr-yoo Jan 25, 2026
4036453
Update .github/workflows/cd.yml
mr-yoo Jan 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .github/workflows/cd.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ jobs:
steps:
- name: Checkout
uses: actions/checkout@v4
with:
fetch-depth: 0

- name: Set up Python
uses: actions/setup-python@v4
Expand All @@ -31,6 +33,11 @@ jobs:
python -m pip install --upgrade pip
pip install build twine

- name: Verify version
run: |
python -m pip install setuptools-scm
python -m setuptools_scm

Comment on lines +36 to +40
Copy link

Copilot AI Jan 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The setuptools-scm package is already declared in pyproject.toml's build-system.requires, so it will be installed automatically when running python -m build in the next step. This separate installation step is redundant. Consider removing this step or moving it after the build step if the intent is to verify the version was correctly detected.

Suggested change
- name: Verify version
run: |
python -m pip install setuptools-scm
python -m setuptools_scm

Copilot uses AI. Check for mistakes.
- name: Build distributions
run: python -m build

Expand Down
20 changes: 10 additions & 10 deletions tests/cassettes/etf/elw_ticker_list.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
interactions:
- request:
body: indIdx2=001&indIdx=1&strtDd=20260117&endDd=20260124&bld=dbms%2FMDC%2FSTAT%2Fstandard%2FMDCSTAT00301
body: indIdx2=001&indIdx=1&strtDd=20260118&endDd=20260125&bld=dbms%2FMDC%2FSTAT%2Fstandard%2FMDCSTAT00301
headers:
Accept:
- '*/*'
Accept-Encoding:
- gzip, deflate
- gzip, deflate, br, zstd
Connection:
- keep-alive
Content-Length:
Expand All @@ -20,8 +20,8 @@ interactions:
uri: https://data.krx.co.kr/comm/bldAttendant/getJsonData.cmd
response:
body:
string: '{"output":[{"TRD_DD":"2026/01/23","CLSPRC_IDX":"4,990.07","FLUC_TP_CD":"1","PRV_DD_CMPR":"37.54","UPDN_RATE":"0.76","OPNPRC_IDX":"4,984.08","HGPRC_IDX":"5,021.13","LWPRC_IDX":"4,926.22","ACC_TRDVOL":"612,601,752","ACC_TRDVAL":"30,017,138,130,375","MKTCAP":"4,125,555,096,685,080"},{"TRD_DD":"2026/01/22","CLSPRC_IDX":"4,952.53","FLUC_TP_CD":"1","PRV_DD_CMPR":"42.60","UPDN_RATE":"0.87","OPNPRC_IDX":"4,987.06","HGPRC_IDX":"5,019.54","LWPRC_IDX":"4,934.17","ACC_TRDVOL":"568,624,077","ACC_TRDVAL":"32,919,611,108,208","MKTCAP":"4,095,874,148,435,200"},{"TRD_DD":"2026/01/21","CLSPRC_IDX":"4,909.93","FLUC_TP_CD":"1","PRV_DD_CMPR":"24.18","UPDN_RATE":"0.49","OPNPRC_IDX":"4,808.94","HGPRC_IDX":"4,910.54","LWPRC_IDX":"4,807.13","ACC_TRDVOL":"600,101,467","ACC_TRDVAL":"30,093,031,855,585","MKTCAP":"4,061,917,379,318,616"},{"TRD_DD":"2026/01/20","CLSPRC_IDX":"4,885.75","FLUC_TP_CD":"2","PRV_DD_CMPR":"-18.91","UPDN_RATE":"-0.39","OPNPRC_IDX":"4,900.28","HGPRC_IDX":"4,935.48","LWPRC_IDX":"4,823.88","ACC_TRDVOL":"667,709,207","ACC_TRDVAL":"27,148,846,770,961","MKTCAP":"4,038,612,917,321,370"},{"TRD_DD":"2026/01/19","CLSPRC_IDX":"4,904.66","FLUC_TP_CD":"1","PRV_DD_CMPR":"63.92","UPDN_RATE":"1.32","OPNPRC_IDX":"4,829.40","HGPRC_IDX":"4,917.37","LWPRC_IDX":"4,827.95","ACC_TRDVOL":"570,841,030","ACC_TRDVAL":"25,214,738,198,401","MKTCAP":"4,056,832,202,296,880"}],"CURRENT_DATETIME":"2026.01.24
PM 08:15:06"}'
string: '{"output":[{"TRD_DD":"2026/01/23","CLSPRC_IDX":"4,990.07","FLUC_TP_CD":"1","PRV_DD_CMPR":"37.54","UPDN_RATE":"0.76","OPNPRC_IDX":"4,984.08","HGPRC_IDX":"5,021.13","LWPRC_IDX":"4,926.22","ACC_TRDVOL":"612,601,752","ACC_TRDVAL":"30,017,138,130,375","MKTCAP":"4,125,555,096,685,080"},{"TRD_DD":"2026/01/22","CLSPRC_IDX":"4,952.53","FLUC_TP_CD":"1","PRV_DD_CMPR":"42.60","UPDN_RATE":"0.87","OPNPRC_IDX":"4,987.06","HGPRC_IDX":"5,019.54","LWPRC_IDX":"4,934.17","ACC_TRDVOL":"568,624,077","ACC_TRDVAL":"32,919,611,108,208","MKTCAP":"4,095,874,148,435,200"},{"TRD_DD":"2026/01/21","CLSPRC_IDX":"4,909.93","FLUC_TP_CD":"1","PRV_DD_CMPR":"24.18","UPDN_RATE":"0.49","OPNPRC_IDX":"4,808.94","HGPRC_IDX":"4,910.54","LWPRC_IDX":"4,807.13","ACC_TRDVOL":"600,101,467","ACC_TRDVAL":"30,093,031,855,585","MKTCAP":"4,061,917,379,318,616"},{"TRD_DD":"2026/01/20","CLSPRC_IDX":"4,885.75","FLUC_TP_CD":"2","PRV_DD_CMPR":"-18.91","UPDN_RATE":"-0.39","OPNPRC_IDX":"4,900.28","HGPRC_IDX":"4,935.48","LWPRC_IDX":"4,823.88","ACC_TRDVOL":"667,709,207","ACC_TRDVAL":"27,148,846,770,961","MKTCAP":"4,038,612,917,321,370"},{"TRD_DD":"2026/01/19","CLSPRC_IDX":"4,904.66","FLUC_TP_CD":"1","PRV_DD_CMPR":"63.92","UPDN_RATE":"1.32","OPNPRC_IDX":"4,829.40","HGPRC_IDX":"4,917.37","LWPRC_IDX":"4,827.95","ACC_TRDVOL":"570,841,030","ACC_TRDVAL":"25,214,738,198,401","MKTCAP":"4,056,832,202,296,880"}],"CURRENT_DATETIME":"2026.01.25
PM 12:09:39"}'
headers:
Cache-Control:
- max-age=0, no-cache, no-store
Expand All @@ -34,16 +34,16 @@ interactions:
Content-Type:
- text/html; charset=utf-8
Date:
- Sat, 24 Jan 2026 11:15:06 GMT
- Sun, 25 Jan 2026 03:09:39 GMT
Expires:
- Sat, 24 Jan 2026 11:15:06 GMT
- Sun, 25 Jan 2026 03:09:39 GMT
Pragma:
- no-cache
Set-Cookie:
- __smVisitorID=QQnCqe4_gXn; Expires=Sun, 24-Jan-2027 11:15:06 GMT; Path=/
- __smVisitorID=sLQu9mQ4Pcg; Expires=Sun, 24-Jan-2027 11:15:06 GMT; Path=/
- __smVisitorID=RKtdbkrNBSq; Expires=Sun, 24-Jan-2027 11:15:06 GMT; Path=/
- JSESSIONID=fCE8TpgL24lcZjsrtXF8XD6HU5r1KRNgdrnZuP2yrrORCn71teSQx8uYGpbHrhJi.bWRjX2RvbWFpbi9tZGNvd2FwMS1tZGNhcHAwMQ==;
- __smVisitorID=Zw_FhxxbYk6; Expires=Mon, 25-Jan-2027 03:09:39 GMT; Path=/
- __smVisitorID=ZiVviMs2PVL; Expires=Mon, 25-Jan-2027 03:09:39 GMT; Path=/
- __smVisitorID=GDgkYzTSVr2; Expires=Mon, 25-Jan-2027 03:09:39 GMT; Path=/
- JSESSIONID=IoAx5GioF65etQWl1wu0azXalYXqUnuQcrUK36VihM6YlwCetTfk7hHKJFU0WpCO.bWRjX2RvbWFpbi9tZGNvd2FwMi1tZGNhcHAxMQ==;
Domain=.krx.co.kr; Path=/; HttpOnly
Vary:
- Accept-Encoding
Expand Down
20 changes: 10 additions & 10 deletions tests/cassettes/etf/etn_ticker_list.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
interactions:
- request:
body: indIdx2=001&indIdx=1&strtDd=20260117&endDd=20260124&bld=dbms%2FMDC%2FSTAT%2Fstandard%2FMDCSTAT00301
body: indIdx2=001&indIdx=1&strtDd=20260118&endDd=20260125&bld=dbms%2FMDC%2FSTAT%2Fstandard%2FMDCSTAT00301
headers:
Accept:
- '*/*'
Accept-Encoding:
- gzip, deflate
- gzip, deflate, br, zstd
Connection:
- keep-alive
Content-Length:
Expand All @@ -20,8 +20,8 @@ interactions:
uri: https://data.krx.co.kr/comm/bldAttendant/getJsonData.cmd
response:
body:
string: '{"output":[{"TRD_DD":"2026/01/23","CLSPRC_IDX":"4,990.07","FLUC_TP_CD":"1","PRV_DD_CMPR":"37.54","UPDN_RATE":"0.76","OPNPRC_IDX":"4,984.08","HGPRC_IDX":"5,021.13","LWPRC_IDX":"4,926.22","ACC_TRDVOL":"612,601,752","ACC_TRDVAL":"30,017,138,130,375","MKTCAP":"4,125,555,096,685,080"},{"TRD_DD":"2026/01/22","CLSPRC_IDX":"4,952.53","FLUC_TP_CD":"1","PRV_DD_CMPR":"42.60","UPDN_RATE":"0.87","OPNPRC_IDX":"4,987.06","HGPRC_IDX":"5,019.54","LWPRC_IDX":"4,934.17","ACC_TRDVOL":"568,624,077","ACC_TRDVAL":"32,919,611,108,208","MKTCAP":"4,095,874,148,435,200"},{"TRD_DD":"2026/01/21","CLSPRC_IDX":"4,909.93","FLUC_TP_CD":"1","PRV_DD_CMPR":"24.18","UPDN_RATE":"0.49","OPNPRC_IDX":"4,808.94","HGPRC_IDX":"4,910.54","LWPRC_IDX":"4,807.13","ACC_TRDVOL":"600,101,467","ACC_TRDVAL":"30,093,031,855,585","MKTCAP":"4,061,917,379,318,616"},{"TRD_DD":"2026/01/20","CLSPRC_IDX":"4,885.75","FLUC_TP_CD":"2","PRV_DD_CMPR":"-18.91","UPDN_RATE":"-0.39","OPNPRC_IDX":"4,900.28","HGPRC_IDX":"4,935.48","LWPRC_IDX":"4,823.88","ACC_TRDVOL":"667,709,207","ACC_TRDVAL":"27,148,846,770,961","MKTCAP":"4,038,612,917,321,370"},{"TRD_DD":"2026/01/19","CLSPRC_IDX":"4,904.66","FLUC_TP_CD":"1","PRV_DD_CMPR":"63.92","UPDN_RATE":"1.32","OPNPRC_IDX":"4,829.40","HGPRC_IDX":"4,917.37","LWPRC_IDX":"4,827.95","ACC_TRDVOL":"570,841,030","ACC_TRDVAL":"25,214,738,198,401","MKTCAP":"4,056,832,202,296,880"}],"CURRENT_DATETIME":"2026.01.24
PM 08:15:06"}'
string: '{"output":[{"TRD_DD":"2026/01/23","CLSPRC_IDX":"4,990.07","FLUC_TP_CD":"1","PRV_DD_CMPR":"37.54","UPDN_RATE":"0.76","OPNPRC_IDX":"4,984.08","HGPRC_IDX":"5,021.13","LWPRC_IDX":"4,926.22","ACC_TRDVOL":"612,601,752","ACC_TRDVAL":"30,017,138,130,375","MKTCAP":"4,125,555,096,685,080"},{"TRD_DD":"2026/01/22","CLSPRC_IDX":"4,952.53","FLUC_TP_CD":"1","PRV_DD_CMPR":"42.60","UPDN_RATE":"0.87","OPNPRC_IDX":"4,987.06","HGPRC_IDX":"5,019.54","LWPRC_IDX":"4,934.17","ACC_TRDVOL":"568,624,077","ACC_TRDVAL":"32,919,611,108,208","MKTCAP":"4,095,874,148,435,200"},{"TRD_DD":"2026/01/21","CLSPRC_IDX":"4,909.93","FLUC_TP_CD":"1","PRV_DD_CMPR":"24.18","UPDN_RATE":"0.49","OPNPRC_IDX":"4,808.94","HGPRC_IDX":"4,910.54","LWPRC_IDX":"4,807.13","ACC_TRDVOL":"600,101,467","ACC_TRDVAL":"30,093,031,855,585","MKTCAP":"4,061,917,379,318,616"},{"TRD_DD":"2026/01/20","CLSPRC_IDX":"4,885.75","FLUC_TP_CD":"2","PRV_DD_CMPR":"-18.91","UPDN_RATE":"-0.39","OPNPRC_IDX":"4,900.28","HGPRC_IDX":"4,935.48","LWPRC_IDX":"4,823.88","ACC_TRDVOL":"667,709,207","ACC_TRDVAL":"27,148,846,770,961","MKTCAP":"4,038,612,917,321,370"},{"TRD_DD":"2026/01/19","CLSPRC_IDX":"4,904.66","FLUC_TP_CD":"1","PRV_DD_CMPR":"63.92","UPDN_RATE":"1.32","OPNPRC_IDX":"4,829.40","HGPRC_IDX":"4,917.37","LWPRC_IDX":"4,827.95","ACC_TRDVOL":"570,841,030","ACC_TRDVAL":"25,214,738,198,401","MKTCAP":"4,056,832,202,296,880"}],"CURRENT_DATETIME":"2026.01.25
PM 12:09:39"}'
headers:
Cache-Control:
- max-age=0, no-cache, no-store
Expand All @@ -34,16 +34,16 @@ interactions:
Content-Type:
- text/html; charset=utf-8
Date:
- Sat, 24 Jan 2026 11:15:06 GMT
- Sun, 25 Jan 2026 03:09:39 GMT
Expires:
- Sat, 24 Jan 2026 11:15:06 GMT
- Sun, 25 Jan 2026 03:09:39 GMT
Pragma:
- no-cache
Set-Cookie:
- __smVisitorID=GjtYl6lUzhj; Expires=Sun, 24-Jan-2027 11:15:06 GMT; Path=/
- __smVisitorID=jDkrUFpTQk9; Expires=Sun, 24-Jan-2027 11:15:06 GMT; Path=/
- __smVisitorID=V6qpc8Hj2Zd; Expires=Sun, 24-Jan-2027 11:15:06 GMT; Path=/
- JSESSIONID=fHCOUFNI1ziNcphctQS8lqmAknFSEJ7Fdvr4WXJaa9SShpjjtjFuUCaV986SMWBM.bWRjX2RvbWFpbi9tZGNvd2FwMi1tZGNhcHAxMQ==;
- __smVisitorID=GuIU16xe90e; Expires=Mon, 25-Jan-2027 03:09:39 GMT; Path=/
- __smVisitorID=GBqWR-RD07S; Expires=Mon, 25-Jan-2027 03:09:39 GMT; Path=/
- __smVisitorID=s2IJwFn0_Xh; Expires=Mon, 25-Jan-2027 03:09:39 GMT; Path=/
- JSESSIONID=InVEea6T7NWXwXiP11hssvH3bDiLuuqCcKqyiDTPn0aP1d6Dt2e7UV7a8kitCiE2.bWRjX2RvbWFpbi9tZGNvd2FwMi1tZGNhcHAwMQ==;
Domain=.krx.co.kr; Path=/; HttpOnly
Vary:
- Accept-Encoding
Expand Down
Loading
Loading