Skip to content

GOLD-265 -- feat: add timestamp when subscribing socketio to consensors#81

Merged
S0naliThakur merged 2 commits intodevfrom
GOLD-265
Oct 23, 2024
Merged

GOLD-265 -- feat: add timestamp when subscribing socketio to consensors#81
S0naliThakur merged 2 commits intodevfrom
GOLD-265

Conversation

@kgmyatthu
Copy link
Copy Markdown
Contributor

No description provided.

@github-actions
Copy link
Copy Markdown
Contributor

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Key issues to review

Hardcoded Protocol
The connection protocol is hardcoded to 'http'. Consider using 'https' for secure communication or making the protocol configurable.

Timestamp Integrity
The timestamp is generated client-side in the Date.now() call. This can be manipulated and may not be reliable for critical operations. Consider server-side timestamp validation or generation.

arhamj
arhamj previously approved these changes Sep 13, 2024
@S0naliThakur S0naliThakur merged commit 66e31b3 into dev Oct 23, 2024
urnotsam pushed a commit that referenced this pull request Oct 30, 2024
…rs (#81)

* feat: add timestamp when subscribing socketio to consensors

* feat: include consensor pubkey in the sig to prevent replay
@mhanson-github mhanson-github deleted the GOLD-265 branch April 7, 2025 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants