Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughA new markdown guide is added at Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
| **If only PR number is provided (fetch all PR review comments):** | ||
|
|
||
| ```bash | ||
| gh api repos/${REPO}/pulls/{PR_NUMBER}/comments | jq '[.[] | {id: .id, path: .path, body: .body, line: .line, start_line: .start_line, user: .user.login, in_reply_to_id: .in_reply_to_id}]' |
There was a problem hiding this comment.
The gh api command supports --paginate which automatically handles multi-page responses. Since pagination is called out as a known limitation, this is an easy fix:
| gh api repos/${REPO}/pulls/{PR_NUMBER}/comments | jq '[.[] | {id: .id, path: .path, body: .body, line: .line, start_line: .start_line, user: .user.login, in_reply_to_id: .in_reply_to_id}]' | |
| gh api --paginate repos/${REPO}/pulls/{PR_NUMBER}/comments | jq '[.[] | {id: .id, path: .path, body: .body, line: .line, start_line: .start_line, user: .user.login, in_reply_to_id: .in_reply_to_id}]' |
| **If only PR number is provided (fetch all PR review comments):** | ||
|
|
||
| ```bash | ||
| gh api repos/${REPO}/pulls/{PR_NUMBER}/comments | jq '[.[] | {id: .id, path: .path, body: .body, line: .line, start_line: .start_line, user: .user.login, in_reply_to_id: .in_reply_to_id}]' |
There was a problem hiding this comment.
Also, when fetching by PR number only, top-level issue comments (/issues/{PR_NUMBER}/comments) are not fetched — only inline review comments are. Reviewers frequently leave general feedback as top-level comments on the PR discussion thread. Consider adding a second fetch:
gh api --paginate repos/${REPO}/issues/{PR_NUMBER}/comments | jq '[.[] | select(.user.login | endswith("[bot]") | not) | {id: .id, body: .body, user: .user.login, html_url: .html_url}]'Then merge and de-duplicate results before creating todos.
| - One todo per actionable review comment/suggestion | ||
| - For file-specific comments: `"{file}:{line} - {comment_summary} (@{username})"` (content) | ||
| - For general comments: Parse the comment body and extract actionable items | ||
| - Format activeForm: `"Addressing {brief description}"` |
There was a problem hiding this comment.
activeForm is not a field in the TodoWrite tool — todos only have content, status, and id. This looks like leftover terminology from a different tool or an earlier draft. Suggest removing this line to avoid confusing the AI that executes the command:
| - Format activeForm: `"Addressing {brief description}"` | |
| - For file-specific comments: `"{file}:{line} - {comment_summary} (@{username})"` (content) | |
| - For general comments: Parse the comment body and extract actionable items | |
| - All todos should start with status: `"pending"` |
| ## Step 6: Address Items and Reply | ||
|
|
||
| When addressing items, after completing each todo item, reply to the original review comment explaining how it was addressed. | ||
|
|
||
| **For issue comments (general PR comments):** | ||
|
|
||
| ```bash | ||
| gh api repos/${REPO}/issues/{PR_NUMBER}/comments -X POST -f body="<response>" | ||
| ``` | ||
|
|
||
| **For PR review comments (file-specific, replying to a thread):** | ||
|
|
||
| ```bash | ||
| gh api repos/${REPO}/pulls/{PR_NUMBER}/comments/{COMMENT_ID}/replies -X POST -f body="<response>" | ||
| ``` | ||
|
|
||
| **For standalone review comments (not in a thread):** |
There was a problem hiding this comment.
The three reply strategies lack clear decision criteria, and the "standalone review comment" case is rarely correct when responding to existing feedback. A clearer decision tree would help:
- If the comment has a
comment_id(inline review comment): usePOST /pulls/{PR}/comments/{COMMENT_ID}/replies - If it's a top-level issue comment (from the
/issues/{PR}/commentsendpoint): usePOST /issues/{PR}/comments - The standalone
POST /pulls/{PR}/commentspath (withcommit_id,path,line) is for creating new review threads, not replying — it should be removed or moved to a separate "creating new comments" section to avoid confusion.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b276a2f0f9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| **If a specific review ID is provided (`#pullrequestreview-...`):** | ||
|
|
||
| ```bash | ||
| gh api repos/${REPO}/pulls/{PR_NUMBER}/reviews/{REVIEW_ID}/comments | jq '[.[] | {id: .id, path: .path, body: .body, line: .line, start_line: .start_line, user: .user.login}]' |
There was a problem hiding this comment.
Using GET /pulls/{PR_NUMBER}/reviews/{REVIEW_ID}/comments only returns inline diff comments, so a review URL like #pullrequestreview-... that contains only an overall review message (no line comments) will produce an empty result and lose actionable feedback. This breaks the advertised flow for specific review URLs because the command never fetches the review object's own body text.
Useful? React with 👍 / 👎.
| **If only PR number is provided (fetch all PR review comments):** | ||
|
|
||
| ```bash | ||
| gh api repos/${REPO}/pulls/{PR_NUMBER}/comments | jq '[.[] | {id: .id, path: .path, body: .body, line: .line, start_line: .start_line, user: .user.login, in_reply_to_id: .in_reply_to_id}]' |
There was a problem hiding this comment.
The PR-number path only calls GET /pulls/{PR_NUMBER}/comments, which excludes general PR discussion comments from issues/{PR_NUMBER}/comments; as a result, /address-review 12345 misses non-inline reviewer feedback unless the user supplies an #issuecomment-... URL explicitly. This causes incomplete todo generation for common reviews that mix inline and general comments.
Useful? React with 👍 / 👎.
|
|
||
| - Rate limiting: GitHub API has rate limits; if you hit them, wait a few minutes | ||
| - Private repos: Requires appropriate `gh` authentication scope | ||
| - Large PRs: PRs with many comments may require pagination (not currently handled) |
There was a problem hiding this comment.
As noted above, gh api --paginate handles pagination automatically and is a one-word fix. Suggest either fixing it or removing this from Known Limitations once fixed:
| - Large PRs: PRs with many comments may require pagination (not currently handled) | |
| - Large PRs: PRs with many comments use `--paginate` to fetch all pages automatically |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
|
|
||
| ## Step 2: Parse User Input | ||
|
|
||
| Extract the PR number and optional review/comment ID from the user's message: |
There was a problem hiding this comment.
Missing $ARGUMENTS prevents receiving user's PR input
High Severity
The command never references the $ARGUMENTS template variable, so when a user invokes /address-review 12345 or /address-review https://github.com/org/repo/pull/12345, the PR number or URL is not injected into the prompt. The sibling command update-changelog.md correctly references $ARGUMENTS on its line 7. Without it, Claude won't know which PR the user wants to review, making the command non-functional.
|
|
||
| ```bash | ||
| gh api repos/${REPO}/pulls/{PR_NUMBER}/comments -X POST -f body="<response>" -f commit_id="<COMMIT_SHA>" -f path="<FILE_PATH>" -f line=<LINE_NUMBER> -f side="RIGHT" | ||
| ``` |
There was a problem hiding this comment.
Standalone comment reply creates new disconnected comment
Medium Severity
The "standalone review comments" case in Step 6 uses the POST /repos/{owner}/{repo}/pulls/{pull_number}/comments endpoint with path, line, and side parameters, which creates a brand-new standalone review comment rather than replying to the original. The correct endpoint for replying to any review comment (standalone or threaded) is the same /replies endpoint used in the case above it: POST .../comments/{COMMENT_ID}/replies.
Greptile SummaryThis PR adds a new Claude custom command ( Key findings:
Confidence Score: 2/5
Sequence DiagramsequenceDiagram
participant User
participant Claude
participant ghCLI as gh CLI
participant GitHubAPI as GitHub API
User->>Claude: /address-review <PR number or URL>
Claude->>ghCLI: gh repo view --json nameWithOwner
ghCLI-->>Claude: REPO
alt specific issuecomment ID
Claude->>GitHubAPI: GET /repos/{REPO}/issues/comments/{COMMENT_ID}
GitHubAPI-->>Claude: single comment
else specific pullrequestreview ID
Claude->>GitHubAPI: GET /repos/{REPO}/pulls/{PR}/reviews/{REVIEW_ID}/comments
GitHubAPI-->>Claude: review comments
else PR number only
Claude->>GitHubAPI: GET /repos/{REPO}/pulls/{PR}/comments
GitHubAPI-->>Claude: inline review comments
Note over Claude,GitHubAPI: ⚠️ Issue-level comments NOT fetched
end
Claude->>Claude: Filter replies & bots (per steps 54-58)
Claude->>Claude: TodoWrite — create pending todos
Claude-->>User: Present N actionable items, wait for direction
User->>Claude: "Address items 1, 2"
Claude->>Claude: Implement fixes
Claude->>GitHubAPI: POST reply to comment thread
GitHubAPI-->>Claude: 201 Created
Claude-->>User: Summary of changes made
Last reviewed commit: b276a2f |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| **If only PR number is provided (fetch all PR review comments):** | ||
|
|
||
| ```bash | ||
| gh api repos/${REPO}/pulls/{PR_NUMBER}/comments | jq '[.[] | {id: .id, path: .path, body: .body, line: .line, start_line: .start_line, user: .user.login, in_reply_to_id: .in_reply_to_id}]' | ||
| ``` |
There was a problem hiding this comment.
General PR discussion comments not fetched
When using the "PR number only" case, only inline code review comments are retrieved via /pulls/{PR_NUMBER}/comments. However, general discussion comments left in the PR timeline (e.g., a reviewer's overall feedback posted in the "Leave a comment" box) are stored at a different GitHub API endpoint: /issues/{PR_NUMBER}/comments.
These are two distinct resources:
GET /repos/{REPO}/pulls/{PR_NUMBER}/comments→ inline code review comments onlyGET /repos/{REPO}/issues/{PR_NUMBER}/comments→ general PR discussion/timeline comments
Reviewers frequently leave actionable feedback as general comments (not tied to a specific line), so these would be silently skipped with the current approach. Consider also fetching issue-level comments when a PR number is provided:
gh api repos/${REPO}/issues/{PR_NUMBER}/comments | jq '[.[] | {id: .id, body: .body, user: .user.login, html_url: .html_url}]'| **For standalone review comments (not in a thread):** | ||
|
|
||
| ```bash | ||
| gh api repos/${REPO}/pulls/{PR_NUMBER}/comments -X POST -f body="<response>" -f commit_id="<COMMIT_SHA>" -f path="<FILE_PATH>" -f line=<LINE_NUMBER> -f side="RIGHT" | ||
| ``` |
There was a problem hiding this comment.
<COMMIT_SHA> placeholder is undefined
The standalone review comment POST call on line 103 requires a commit_id parameter, but the command does not explain how to obtain <COMMIT_SHA>. Without this guidance, an agent following these instructions would be unable to correctly fill in this placeholder.
The commit SHA should be fetched from the PR's head commit. Add this before the POST call:
COMMIT_SHA=$(gh api repos/${REPO}/pulls/{PR_NUMBER} | jq -r '.head.sha')Then use $COMMIT_SHA in the POST command on line 103.
### Summary Adds the address-review command that fetches GitHub PR review comments and creates todos to address them. This command was ported from the React on Rails repository and provides functionality to extract, filter, and organize review feedback from GitHub PRs. ### Pull Request checklist - ~[ ] Add/update test to cover these changes~ - ~[ ] Update documentation~ - ~[ ] Update CHANGELOG file~ ### Other Information This is a new custom command for the project, no CHANGELOG update needed. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Documentation-only addition of a workflow command; no application/runtime code paths are modified. > > **Overview** > Adds a new Claude custom command, `/.address-review`, documented in `.claude/commands/address-review.md`, to fetch GitHub PR review/issue comments via `gh api`, filter to actionable top-level (non-bot) feedback, and turn them into a pending todo list for the user to select from. > > Also documents the follow-up workflow for replying back to the appropriate GitHub comment threads after fixes are made, including the relevant API calls and expected response content. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit b276a2f. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
## Summary - Added [Unreleased] changelog entries for two merged PRs missing from CHANGELOG.md: - **PR #963**: Fixed `Env#current` crashing when Rails is not loaded (bug fix by @ihabadham) - **PR #900**: Added Node package API documentation (by @justin808) - Skipped non-user-visible PRs: #958, #957, #959 ## Test plan - [x] `yarn lint` passes - [x] Changelog formatting matches existing conventions 🤖 Generated with [Claude Code](https://claude.com/claude-code) <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Documentation-only change confined to `CHANGELOG.md`, with no runtime or build behavior impact. > > **Overview** > Updates `CHANGELOG.md` under **[Unreleased]** to document two previously-merged changes: a fix preventing `Env#current` from crashing when Rails isn’t loaded, and new documentation for the Node package JavaScript API (`docs/node_package_api.md`). > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 81bf2b8. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
1 participant
Summary
Adds the address-review command that fetches GitHub PR review comments and creates todos to address them. This command was ported from the React on Rails repository and provides functionality to extract, filter, and organize review feedback from GitHub PRs.
Pull Request checklist
[ ] Add/update test to cover these changes[ ] Update documentation[ ] Update CHANGELOG fileOther Information
This is a new custom command for the project, no CHANGELOG update needed.
Note
Low Risk
Documentation-only addition of a workflow command; no application/runtime code paths are modified.
Overview
Adds a new Claude custom command,
/.address-review, documented in.claude/commands/address-review.md, to fetch GitHub PR review/issue comments viagh api, filter to actionable top-level (non-bot) feedback, and turn them into a pending todo list for the user to select from.Also documents the follow-up workflow for replying back to the appropriate GitHub comment threads after fixes are made, including the relevant API calls and expected response content.
Written by Cursor Bugbot for commit b276a2f. Configure here.
Summary by CodeRabbit