feat: add support for determining Shakapacker version via pnpm-lock.yaml#352
Merged
Judahmeek merged 1 commit intoshakacode:masterfrom Aug 28, 2023
G-Rath:support-pnpm-lock
Merged
feat: add support for determining Shakapacker version via pnpm-lock.yaml#352Judahmeek merged 1 commit intoshakacode:masterfrom G-Rath:support-pnpm-lock
pnpm-lock.yaml#352Judahmeek merged 1 commit intoshakacode:masterfrom
G-Rath:support-pnpm-lock
Conversation
Judahmeek
approved these changes
Aug 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for determining the version of Shakapacker being installed when
pnpmis the package manager; while that is not officially supported by Shakapacker (yet 🤞), given this is stable and small I think its worth landing ahead of #349.Pull Request checklist
Update documentationOther Information
Pulled from #349