Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #8771
The Progress component was not passing the
valueprop to the underlyingProgressPrimitive.Rootcomponent from Radix UI. While basic ARIA attributes were present, the current progress value was missing, causing the component to always appear as "indeterminate" to screen readers.Changes
value={value}prop toProgressPrimitive.Rootin the Progress componentaria-valuenowanddata-valueattributes to properly reflect the current progressThe Problem
Without passing the
valueprop, the progress bar was treated as indeterminate, meaning screen readers couldn't announce the actual progress percentage to users.Testing
aria-valuenowanddata-valueattributes are now present with correct valuesdata-statechanges from "indeterminate" to "loading"/"complete"Before
After
Checklist
pnpm registry:build)