Skip to content

Conversation

@mixon00
Copy link

@mixon00 mixon00 commented Nov 16, 2025

Description

Fixes #8771

The Progress component was not passing the value prop to the underlying ProgressPrimitive.Root component from Radix UI. While basic ARIA attributes were present, the current progress value was missing, causing the component to always appear as "indeterminate" to screen readers.

Changes

  • Added value={value} prop to ProgressPrimitive.Root in the Progress component
  • This enables aria-valuenow and data-value attributes to properly reflect the current progress

The Problem

Without passing the value prop, the progress bar was treated as indeterminate, meaning screen readers couldn't announce the actual progress percentage to users.

Testing

  • Manually tested the Progress component locally
  • Verified aria-valuenow and data-value attributes are now present with correct values
  • Confirmed data-state changes from "indeterminate" to "loading"/"complete"
  • Registry build completed successfully
  • Component styling and functionality remain unchanged

Before

<div role="progressbar" aria-valuemax="100" aria-valuemin="0" data-state="indeterminate" data-max="100">
  <!-- Missing: aria-valuenow and data-value -->
</div>

After

<div role="progressbar" aria-valuenow="66" aria-valuemax="100" aria-valuemin="0" data-value="66" data-state="loading" data-max="100">
  <!-- Now includes current value! -->
</div>

Checklist

  • Code follows the commit conventions
  • Registry has been rebuilt (pnpm registry:build)
  • Changes tested locally
  • Accessibility verified

- Passes value prop to ProgressPrimitive.Root for accessibility support
- Enables proper ARIA attributes (aria-valuenow, aria-valuemax, etc.)
- Fixes screen reader announcements

Fixes shadcn-ui#8771
- Passes value prop to ProgressPrimitive.Root for accessibility support
- Enables proper ARIA attributes (aria-valuenow, aria-valuemax, etc.)
- Fixes screen reader announcements

Fixes shadcn-ui#8771
@vercel
Copy link

vercel bot commented Nov 16, 2025

@mixon00 is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug]: Progress component not using value prop by default

1 participant