refactor(components): use explicit interfaces for component props #7605
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @shadcn!
I've been working components types and thought we could improve the developer experience by using explicit type aliases instead of inline
React.ComponentPropstypes (for v4, maybe we should also add it for v3?).Changes
export type {}Benefits
This is a non-breaking change that improves TypeScript developer experience without affecting runtime behavior. Planning to roll this out to more components if this approach looks good!
Related issues
Close: #51, #120, #167, #448, #739, #1013, #2014, #4082, #4083, #7570