[Optimization] Update estimated_num_new_pages logic in TokenToKVPoolAllocator#8794
Merged
merrymercy merged 3 commits intosgl-project:mainfrom Aug 10, 2025
Merged
[Optimization] Update estimated_num_new_pages logic in TokenToKVPoolAllocator#8794merrymercy merged 3 commits intosgl-project:mainfrom
merrymercy merged 3 commits intosgl-project:mainfrom
Conversation
…llocator Signed-off-by: Xingrui Yi <yixingrui@linux.alibaba.com>
YiXR
requested review from
Ying1123,
hnyls2002,
merrymercy and
xiezhq-hermann
as code owners
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
6 tasks
ShangmingCai
reviewed
Aug 5, 2025
merrymercy
reviewed
Aug 7, 2025
Contributor
merrymercy
left a comment
merrymercy
left a comment
There was a problem hiding this comment.
Looks good to me.
It seems this sort is only useful for PD case. Should we add a flag so that it only turns on during PD?
Contributor
Author
done |
xiezhq-hermann
approved these changes
Aug 8, 2025
ShangmingCai
reviewed
Aug 8, 2025
Signed-off-by: Xingrui Yi <yixingrui@linux.alibaba.com>
narutolhy
pushed a commit
to narutolhy/sglang
that referenced
this pull request
Aug 17, 2025
…llocator (sgl-project#8794) Signed-off-by: Xingrui Yi <yixingrui@linux.alibaba.com> Co-authored-by: Xingrui Yi <yixingrui@linux.alibaba.com>
MahmoudAshraf97
pushed a commit
to MahmoudAshraf97/sglang
that referenced
this pull request
Sep 8, 2025
…llocator (sgl-project#8794) Signed-off-by: Xingrui Yi <yixingrui@linux.alibaba.com> Co-authored-by: Xingrui Yi <yixingrui@linux.alibaba.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR update estimated_num_new_pages logic and format code which is introduced by the previous PR: #8133
Modifications
Accuracy Test
Benchmark & Profiling
Checklist