Skip to content

bugfix(hicache): Fix 'MooncakeStore' not defined error. #8668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhyncs merged 2 commits into from
Aug 1, 2025
Merged

bugfix(hicache): Fix 'MooncakeStore' not defined error. #8668

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a51a37f
fix(hicache): Fix 'MooncakeStore' not found error.
hzh0425 Aug 1, 2025
8c0e408
Merge branch 'main' into fix/mooncake-not-found-error
xiezhq-hermann Aug 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions python/sglang/srt/managers/cache_controller.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,6 +236,7 @@ def __init__(
self.enable_storage = False
# todo: move backend initialization to storage backend module
if storage_backend is not None:
self.storage_backend_type = storage_backend
from sglang.srt.mem_cache.hicache_storage import HiCacheFile, get_hash_str

if storage_backend == "file":
Expand Down Expand Up @@ -573,14 +574,17 @@ def mooncake_page_transfer(self, operation):
self.storage_backend.batch_get(key_strs, buffer_ptrs, buffer_sizes)
operation.increment(len(operation.hash_value) * self.page_size)

def is_mooncake_backend(self):
return self.storage_backend_type == "mooncake"

def prefetch_io_aux_func(self):
"""
Auxiliary function conducting IO operations for prefetching.
"""
while not self.stop_event.is_set():
try:
operation = self.prefetch_buffer.get(block=True, timeout=1)
if isinstance(self.storage_backend, MooncakeStore):
if self.is_mooncake_backend():
self.mooncake_page_transfer(operation)
else:
self.generic_page_transfer(operation)
Expand Down Expand Up @@ -615,14 +619,14 @@ def prefetch_thread_func(self):
)

# todo, more unified interface
if not isinstance(self.storage_backend, MooncakeStore):
if not self.is_mooncake_backend():
if not self.storage_backend.exists(last_hash):
break
hash_value.append(last_hash)
storage_hit_count += self.page_size
remaining_tokens -= self.page_size

if isinstance(self.storage_backend, MooncakeStore):
if self.is_mooncake_backend():
# deferring to batch exists for mooncake store
exist_result = self.storage_backend.exists(hash_value)
storage_hit_count = (
Expand Down Expand Up @@ -744,7 +748,7 @@ def backup_thread_func(self):
remaining_tokens -= self.page_size
operation.hash_value = hash_value

if isinstance(self.storage_backend, MooncakeStore):
if self.is_mooncake_backend():
self.mooncake_page_backup(operation)
else:
self.generic_page_backup(operation)
Expand Down
Loading