Skip to content

[bug] remove pdlb from minilb since its no longer available #8634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhyncs merged 2 commits into from
Jul 31, 2025
Merged

[bug] remove pdlb from minilb since its no longer available #8634

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
65e4a04
[bug] remove pdlb from minilb since its no longer available
slin1237 Jul 31, 2025
dd80107
Merge branch 'main' into slin/minilb-fix
slin1237 Jul 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 5 additions & 20 deletions python/sglang/srt/disaggregation/launch_lb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
import argparse
import dataclasses

from sglang.srt.disaggregation.mini_lb import PrefillConfig, run


@dataclasses.dataclass
class LBArgs:
Expand All @@ -18,7 +20,7 @@ def add_cli_args(parser: argparse.ArgumentParser):
parser.add_argument(
"--rust-lb",
action="store_true",
help="Use Rust load balancer",
help="Deprecated, please use SGLang Router instead, this argument will have no effect.",
)
parser.add_argument(
"--host",
Expand Down Expand Up @@ -115,25 +117,8 @@ def main():
args = parser.parse_args()
lb_args = LBArgs.from_cli_args(args)
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Jul 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Now that the Rust load balancer logic has been removed, the conditional check based on lb_args.rust_lb is no longer necessary. You can directly proceed with the mini_lb execution, simplifying the code flow.

prefill_configs = [PrefillConfig(url, port) for url, port in lb_args.prefill_infos]
    run(prefill_configs, lb_args.decode_infos, lb_args.host, lb_args.port)


if lb_args.rust_lb:
from sgl_pdlb._rust import LoadBalancer as RustLB

RustLB(
host=lb_args.host,
port=lb_args.port,
policy=lb_args.policy,
prefill_infos=lb_args.prefill_infos,
decode_infos=lb_args.decode_infos,
log_interval=lb_args.log_interval,
timeout=lb_args.timeout,
).start()
else:
from sglang.srt.disaggregation.mini_lb import PrefillConfig, run

prefill_configs = [
PrefillConfig(url, port) for url, port in lb_args.prefill_infos
]
run(prefill_configs, lb_args.decode_infos, lb_args.host, lb_args.port)
prefill_configs = [PrefillConfig(url, port) for url, port in lb_args.prefill_infos]
run(prefill_configs, lb_args.decode_infos, lb_args.host, lb_args.port)


if __name__ == "__main__":
Expand Down
Loading