Skip to content

Tiny fix CI pytest error #8524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ch-wan merged 4 commits into from
Aug 3, 2025
Merged

Tiny fix CI pytest error #8524

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a6fd297
more
fzyzcjy Jul 29, 2025
c45326a
Merge branch 'main' into feat/fix_pytest
fzyzcjy Jul 29, 2025
a6643de
Merge branch 'main' into feat/fix_pytest
fzyzcjy Jul 29, 2025
a0df779
Merge branch 'main' into feat/fix_pytest
fzyzcjy Jul 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions python/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,7 @@ test = [
"pandas",
"peft",
"sentence_transformers",
"pytest",
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Jul 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Thanks for fixing the CI! For consistency and maintainability, could you please place pytest in its correct alphabetical position within the test dependency list? The list appears to be sorted alphabetically, and pytest should be placed after peft and before sentence_transformers.

]
all = ["sglang[srt]", "sglang[openai]", "sglang[anthropic]", "sglang[litellm]", "sglang[torch_memory_saver]", "sglang[decord]"]
all_hip = ["sglang[srt_hip]", "sglang[openai]", "sglang[anthropic]", "sglang[litellm]", "sglang[decord]"]
Expand Down
Loading