Skip to content

Move SGLang to ToT in Dockerfile.gb200#8497

Closed
kyleliang-nv wants to merge 3 commits intosgl-project:mainfrom
kyleliang-nv:pr/remove_gb200_docker_workaround
Closed

Move SGLang to ToT in Dockerfile.gb200#8497
kyleliang-nv wants to merge 3 commits intosgl-project:mainfrom
kyleliang-nv:pr/remove_gb200_docker_workaround

Conversation

@kyleliang-nv
Copy link
Copy Markdown
Contributor

Motivation

Dockerfile.gb200 currently contains a work-around for flashinfer, due to the missing arm package for 0.2.9rc1.
The problem have since been resolved in flashinfer 0.2.9rc2.
Hence, the work-around is no longer needed.

Modifications

Install ToT Sglang inside Dockerfile.gb200 instead of sglang with flashinfer 0.2.7.post1

Accuracy Test

Benchmark & Profiling

Tested this PR by building/publishing the docker image built with Dockerfile.gb200 onto dockerhub,
verified no performance or health issue regarding running SGLang on GB200.

Checklist

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @kyleliang-nv, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the Dockerfile.gb200 to utilize the most current version of SGLang, removing a specific version pin that was previously required due to a dependency workaround. This change also introduces a minor optimization to the Docker build process.

Highlights

  • SGLang Version Update: The Dockerfile.gb200 has been updated to fetch the latest 'Tip of Tree' (ToT) version of SGLang directly from its Git repository. This removes a previously pinned commit (a167fd0bcb9ef4b0f4331a109e40c8cdc770b026), as the underlying flashinfer issue that necessitated the workaround has been resolved.
  • Docker Build Optimization: The git clone command for SGLang now includes the --depth=1 flag. This optimizes the Docker image build process by performing a shallow clone, fetching only the latest commit and reducing the overall download size and time.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Dockerfile to use the top-of-tree version of SGLang, removing a workaround for a flashinfer packaging issue. The change also uses git clone --depth=1 to reduce the Docker image size.

@kyleliang-nv kyleliang-nv force-pushed the pr/remove_gb200_docker_workaround branch from 498f93f to 51653d9 Compare July 29, 2025 04:48
@kyleliang-nv kyleliang-nv force-pushed the pr/remove_gb200_docker_workaround branch from b83dbef to 8a5094f Compare July 30, 2025 16:46
@kyleliang-nv
Copy link
Copy Markdown
Contributor Author

This PR have been merged byhttps://github.com//pull/8694

@kyleliang-nv kyleliang-nv deleted the pr/remove_gb200_docker_workaround branch August 8, 2025 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants