Skip to content

Don't use auto_model_type._model_mapping.items() in _config_cls_name_…#8423

Merged
hebiao064 merged 1 commit intosgl-project:bhe/bump_transformerfrom
byjiang1996:bhe/bump_transformer
Jul 27, 2025
Merged

Don't use auto_model_type._model_mapping.items() in _config_cls_name_…#8423
hebiao064 merged 1 commit intosgl-project:bhe/bump_transformerfrom
byjiang1996:bhe/bump_transformer

Conversation

@byjiang1996
Copy link
Copy Markdown
Collaborator

…to_arch_name_mapping b/c it was broken in latest transformer

Motivation

Fix TestMistral3_1Server & TestPixtralServer UT failures caused by transformer bug

Modifications

n/a

Checklist

…to_arch_name_mapping b/c it was broken in latest transformer
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @byjiang1996, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request provides a critical fix to ensure compatibility with the latest transformer library, resolving unit test failures related to model server functionalities. The change involves a more robust method of accessing model configuration mappings to adapt to recent upstream library changes.

Highlights

  • Bug Fix & Compatibility: This pull request addresses and resolves unit test failures for TestMistral3_1Server and TestPixtralServer. These failures were caused by a breaking change or unexpected behavior in the _model_mapping.items() method within the latest version of the transformer library.
  • Code Robustness: The _config_cls_name_to_arch_name_mapping function in python/sglang/srt/models/llava.py has been updated. Instead of directly iterating over auto_model_type._model_mapping.items(), it now iterates over the keys and then safely retrieves the corresponding values using get(key, None), including a None check to prevent potential errors.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The code changes address a bug in the transformers library by iterating over the keys of a dictionary instead of using .items(). A suggestion has been made to improve readability.

@hebiao064 hebiao064 merged commit c1328c9 into sgl-project:bhe/bump_transformer Jul 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants