Skip to content

Fix gemma3n with hybrid swa #8240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
slin1237 merged 4 commits into from
Jul 23, 2025
Merged

Fix gemma3n with hybrid swa #8240

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
657bdd9
fix: enable gemma3n using hybrid
JustinTong0323 Jul 21, 2025
b770ca7
fix: add gemma3n to unittest
JustinTong0323 Jul 21, 2025
a50b45d
Increases the timeout for a vision test.
JustinTong0323 Jul 22, 2025
2a4dec9
Merge branch 'main' into fix-gemma3n-hybrid-swa
JustinTong0323 Jul 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions python/sglang/srt/model_executor/model_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,6 +275,7 @@ def initialize(self, min_per_gpu_memory: float):
self.sampler = Sampler()
self.load_model()

# Check if the model is using hybrid SWA
if (
not self.server_args.disable_hybrid_swa_memory
and self.sliding_window_size is not None
Expand Down Expand Up @@ -1010,8 +1011,11 @@ def set_num_token_hybrid(self):
try:
layers = self.model.language_model.model.layers
except:
self.is_hybrid = False
return
try:
layers = self.model.language_model.layers
except:
self.is_hybrid = False
return

for layer in layers:
if (
Expand Down
2 changes: 1 addition & 1 deletion test/srt/run_suite.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ class TestFile:
TestFile("test_vision_chunked_prefill.py", 175),
TestFile("test_vlm_input_format.py", 300),
TestFile("test_vision_openai_server_a.py", 584),
TestFile("test_vision_openai_server_b.py", 556),
TestFile("test_vision_openai_server_b.py", 620),
TestFile("test_w8a8_quantization.py", 46),
TestFile("test_reasoning_parser.py", 5),
],
Expand Down
21 changes: 21 additions & 0 deletions test/srt/test_vision_openai_server_b.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,27 @@ def test_video_chat_completion(self):
pass


class TestGemma3nServer(TestOpenAIVisionServer):
@classmethod
def setUpClass(cls):
cls.model = "google/gemma-3n-E2B-it"
cls.base_url = DEFAULT_URL_FOR_TEST
cls.api_key = "sk-123456"
cls.process = popen_launch_server(
cls.model,
cls.base_url,
timeout=DEFAULT_TIMEOUT_FOR_SERVER_LAUNCH,
other_args=[
"--trust-remote-code",
"--mem-fraction-static",
"0.70",
"--cuda-graph-max-bs",
"1",
],
)
cls.base_url += "/v1"


class TestKimiVLServer(TestOpenAIVisionServer):
@classmethod
def setUpClass(cls):
Expand Down
Loading