-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Fix Dockerfile.gb200 #8169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Dockerfile.gb200 #8169
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -140,8 +140,8 @@ RUN apt-get update && apt-get install -y \ | |
|
|
||
| RUN apt update -y \ | ||
| && apt install -y --no-install-recommends gnupg \ | ||
| && echo "deb http://developer.download.nvidia.com/devtools/repos/ubuntu2204/$(if [ "$(uname -m)" = "aarch64" ]; then echo "arm64"; else echo "amd64"; fi) /" | tee /etc/apt/sources.list.d/nvidia-devtools.list \ | ||
| && apt-key adv --fetch-keys http://developer.download.nvidia.com/compute/cuda/repos/ubuntu2204/$(if [ "$(uname -m)" = "aarch64" ]; then echo "sbsa"; else echo "x86_64"; fi)/3bf863cc.pub \ | ||
| && echo "deb http://developer.download.nvidia.com/devtools/repos/ubuntu2004/$(if [ "$(uname -m)" = "aarch64" ]; then echo "arm64"; else echo "amd64"; fi) /" | tee /etc/apt/sources.list.d/nvidia-devtools.list \ | ||
| && apt-key adv --fetch-keys http://developer.download.nvidia.com/compute/cuda/repos/ubuntu1804/$(if [ "$(uname -m)" = "aarch64" ]; then echo "arm64"; else echo "x86_64"; fi)/7fa2af80.pub \ | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The change reverts to using a GPG key from the Ubuntu 18.04 CUDA repository. Similar to the repository concern, using keys from older Ubuntu versions may introduce compatibility issues or unexpected behavior. Verify that this key is fully compatible with the packages being installed and consider updating to a key that matches the Ubuntu 22.04 base image if possible. |
||
| && apt update -y \ | ||
| && apt install nsight-systems-cli -y | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change reverts to using the Ubuntu 20.04 repository for NVIDIA devtools. While this resolves the immediate issue, using repositories from older Ubuntu versions on a newer base image (Ubuntu 22.04) can lead to potential dependency conflicts and instability in the long term. Consider if there's a more targeted fix or a way to use a repository that aligns with the base OS version.