Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion sgl-router/py_src/sglang_router/launch_router.py
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,8 @@ def add_cli_args(
parser.add_argument(
"--worker-urls",
type=str,
nargs="+",
nargs="*",
default=[],
help="List of worker URLs (e.g., http://worker1:8000 http://worker2:8000)",
)

Expand Down
23 changes: 22 additions & 1 deletion sgl-router/py_test/test_launch_router.py
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,9 @@ def test_launch_router_common(self):

def test_launch_router_with_empty_worker_urls(self):
args = self.create_router_args(worker_urls=[])
self.run_router_process(args) # Expected error
self.run_router_process(
args
) # Should start successfully with empty worker list

def test_launch_router_with_service_discovery(self):
# Test router startup with service discovery enabled but no selectors
Expand Down Expand Up @@ -279,6 +281,25 @@ def test_regular_service_discovery_args_parsing(self):
self.assertEqual(router_args.prefill_selector, {})
self.assertEqual(router_args.decode_selector, {})

def test_empty_worker_urls_args_parsing(self):
"""Test that router accepts no worker URLs and defaults to empty list."""
import argparse

from sglang_router.launch_router import RouterArgs

parser = argparse.ArgumentParser()
RouterArgs.add_cli_args(parser)

# Test with no --worker-urls argument at all
args = parser.parse_args(["--policy", "random", "--port", "30000"])
router_args = RouterArgs.from_cli_args(args)
self.assertEqual(router_args.worker_urls, [])

# Test with explicit empty --worker-urls
args = parser.parse_args(["--worker-urls", "--policy", "random"])
router_args = RouterArgs.from_cli_args(args)
self.assertEqual(router_args.worker_urls, [])


if __name__ == "__main__":
unittest.main()
Loading