Skip to content

feat: add return hidden_states at async generation #7507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhyncs merged 3 commits into from
Jun 25, 2025
Merged

feat: add return hidden_states at async generation #7507

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d27602f
init
yyihuang Jun 25, 2025
4fd1a71
Merge branch 'main' into async_hs
zhyncs Jun 25, 2025
a71ec24
upd
zhyncs Jun 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions python/sglang/srt/entrypoints/engine.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,6 +242,7 @@ async def async_generate(
token_ids_logprob: Optional[Union[List[List[int]], List[int]]] = None,
lora_path: Optional[List[Optional[str]]] = None,
custom_logit_processor: Optional[Union[List[str], str]] = None,
return_hidden_states: bool = False,
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Jun 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The newly added return_hidden_states parameter should be documented within the async_generate function's docstring. This will help users understand its purpose and how to use it effectively.

stream: bool = False,
bootstrap_host: Optional[Union[List[str], str]] = None,
bootstrap_port: Optional[Union[List[int], int]] = None,
Expand Down Expand Up @@ -274,6 +275,7 @@ async def async_generate(
top_logprobs_num=top_logprobs_num,
token_ids_logprob=token_ids_logprob,
lora_path=lora_path,
return_hidden_states=return_hidden_states,
stream=stream,
custom_logit_processor=custom_logit_processor,
bootstrap_host=bootstrap_host,
Expand Down
Loading