Skip to content

Fix the missing 'lof' choice of --schedule-policy server args #7114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhyncs merged 2 commits into from
Aug 3, 2025
Merged

Fix the missing 'lof' choice of --schedule-policy server args #7114

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f35a78d
Fix the missing 'lof' choice of --schedule-policy server args
acelyc111 Jun 12, 2025
d15a255
Merge branch 'main' into fix_add_lof_define
zhyncs Aug 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion python/sglang/srt/server_args.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -868,7 +868,7 @@ def add_cli_args(parser: argparse.ArgumentParser):
"--schedule-policy",
type=str,
default=ServerArgs.schedule_policy,
choices=["lpm", "random", "fcfs", "dfs-weight"],
choices=["lpm", "random", "fcfs", "dfs-weight", "lof"],
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Jun 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This change correctly adds 'lof' as a choice for the scheduling policy, aligning the CLI with implemented functionalities.

To ensure completeness for this user-facing update, please consider the following:

  1. Testing: The 'Add unit tests' item in the pull request checklist is currently unchecked. It would be beneficial to verify that this CLI option change is covered by tests. For instance, a test ensuring that --schedule-policy lof is accepted by the argument parser would be valuable.
  2. Documentation: The 'Update documentation' item in the pull request checklist is also unchecked. Please ensure that any user-facing documentation (e.g., READMEs, usage guides) that lists or describes scheduling policies is updated to include 'lof' as an available option.

help="The scheduling policy of the requests.",
)
parser.add_argument(
Expand Down
Loading