Skip to content

Fix typos in py_test/test_launch_server.py #6227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
slin1237 merged 2 commits into from
Jul 31, 2025
+4 −4
Merged

Fix typos in py_test/test_launch_server.py #6227

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
caf5feb
Fix typos in py_test/test_launch_server.py
windsonsea May 12, 2025
b227f63
Merge branch 'main' into typoy
slin1237 Jul 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions sgl-router/py_test/test_launch_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ def test_2_add_and_remove_worker(self):
)
self.other_process.append(worker_process)

# 2. use /add_worker api to add it the the router. It will be used by router after it is healthy
# 2. use /add_worker api to add it to the router. It will be used by the router after it is healthy
with requests.Session() as session:
response = session.post(f"{self.base_url}/add_worker?url={worker_url}")
print(f"status code: {response.status_code}, response: {response.text}")
Expand Down Expand Up @@ -304,7 +304,7 @@ def test_3_lazy_fault_tolerance(self):
)
self.other_process.append(worker_process)

# 2. use /add_worker api to add it the the router. It will be used by router after it is healthy
# 2. use /add_worker api to add it to the router. It will be used by the router after it is healthy
with requests.Session() as session:
response = session.post(f"{self.base_url}/add_worker?url={worker_url}")
print(f"status code: {response.status_code}, response: {response.text}")
Expand Down Expand Up @@ -340,7 +340,7 @@ def kill_worker():

def test_4_payload_size(self):
print("Running test_4_payload_size...")
# Start router with 3MB limit
# Start router with 1MB limit
self.process = popen_launch_router(
self.model,
self.base_url,
Expand Down Expand Up @@ -398,7 +398,7 @@ def test_5_api_key(self):
api_key="correct_api_key",
)

# # Test case 1: request without api key should fail
# Test case 1: request without api key should fail
with requests.Session() as session:
response = session.post(
f"{self.base_url}/generate",
Expand Down
Loading