Tiny refactor DeepSeek V3/R1 NextN shared experts fusion#5143
Closed
lambert0312 wants to merge 38 commits intosgl-project:mainfrom
Closed
Tiny refactor DeepSeek V3/R1 NextN shared experts fusion#5143lambert0312 wants to merge 38 commits intosgl-project:mainfrom
lambert0312 wants to merge 38 commits intosgl-project:mainfrom
Conversation
23ede5b to
1e854ab
Compare
Contributor
|
will fused shared experts still improve performance with nextn? |
Contributor
Author
Yes, I'm still experimenting with the current effects |
fzyzcjy
reviewed
Apr 10, 2025
6 tasks
Contributor
|
Can you add a test case? |
Contributor
Author
Ok. I will add it |
Collaborator
|
Maybe my PR can be firstly merged to make the commit history a bit more clear |
Contributor
Author
Yes, I'm waiting for it to be merged @fzyzcjy |
668c67c to
5769b91
Compare
Contributor
|
any update in this PR? |
Contributor
Author
No, can merge it in. @xihuai18 |
Collaborator
64e6df1 to
1ee3b6a
Compare
682653d to
6351425
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Ref #4918
Ref #5707
Ref #5793
Modifications
compute_shared_experts_fusion_weightsand put it indeepseek_v2.pyfirst.Acc in A800
Benchmark in A800
Checklist