Skip to content

fix #2528 #2541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zhyncs merged 1 commit into from
Dec 21, 2024
Merged

fix #2528 #2541

zhyncs merged 1 commit into from
Dec 21, 2024

Conversation

@zhyncs
Copy link
Collaborator

@zhyncs zhyncs commented Dec 21, 2024

Motivation

build time error not runtime error

Modifications

Checklist

  • Format your code according to the Contributor Guide.
  • Add unit tests as outlined in the Contributor Guide.
  • Update documentation as needed, including docstrings or example tutorials.

@zhyncs zhyncs merged commit 4e1e3cf into main Dec 21, 2024
7 of 8 checks passed
@zhyncs zhyncs deleted the zhyncs/docker branch December 21, 2024 16:14
chosen-ox pushed a commit to chosen-ox/sglang that referenced this pull request Dec 22, 2024
@zhyncs @chosen-ox
fix sgl-project#2528 (sgl-project#2541)
54a9d69
timethink pushed a commit to timethink/sglang that referenced this pull request Mar 9, 2025
@zhyncs
fix sgl-project#2528 (sgl-project#2541)
d88ab41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zhyncs