Skip to content

Let ModelRunner take InputMetadata as input, instead of ScheduleBatch #1541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merrymercy merged 9 commits into from
Sep 30, 2024
Merged

Let ModelRunner take InputMetadata as input, instead of ScheduleBatch #1541

merrymercy merged 9 commits into from
Sep 30, 2024

Conversation

@merrymercy
Copy link
Contributor

@merrymercy merrymercy commented Sep 30, 2024 •
edited
Loading

  • Let ModelRunner take InputMetadata as input, instead of ScheduleBatch. This makes a better separation between scheduling and model forward pass.
  • Delete the deprecated position_ids_offsets

@merrymercy merrymercy changed the title Let ModelRunner takes InputMetadata as input, instead of ScheduleBatch Let ModelRunner take InputMetadata as input, instead of ScheduleBatch Sep 30, 2024
@merrymercy merrymercy merged commit 3f0fe08 into main Sep 30, 2024
@merrymercy merrymercy deleted the mem-pool branch September 30, 2024 03:28
@merrymercy merrymercy mentioned this pull request Oct 5, 2024
Merged
5 tasks
timethink pushed a commit to timethink/sglang that referenced this pull request Mar 9, 2025
@merrymercy
Let ModelRunner take InputMetadata as input, instead of ScheduleBatch (…
e7f2f74 
…sgl-project#1541)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@merrymercy