Tiny fix test run estimated time#11544
Conversation
Signed-off-by: Shangming Cai <[email protected]>
Summary of ChangesHello @ShangmingCai, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request aims to enhance the stability of the continuous integration (CI) pipeline by correcting underestimated test execution times. Recent additions of test cases in certain files led to CI flakiness, as the system would time out before tests could complete. By updating the estimated run times for these specific test suites, the PR ensures that the CI environment has adequate time to process all tests, preventing premature timeouts and promoting a more reliable build process. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the estimated run times for two test files to fix CI flakiness, which is a good and necessary change. My review includes suggestions to add comments next to the updated times. This should help remind developers to update these values in the future, preventing similar issues. Additionally, I noticed a minor sorting issue in the per-commit-1-gpu test suite that could be addressed in a follow-up to improve code consistency, as batch_invariant/test_batch_invariant_ops.py appears to be out of alphabetical order.
Signed-off-by: Shangming Cai <[email protected]>
Motivation
Main CI is flaky again due to some PRs that added more test cases, but did not increment the estimated time:
Modifications
Accuracy Tests
Benchmarking and Profiling
Checklist