Skip to content

Tiny fix test run estimated time#11544

Merged
ch-wan merged 1 commit intosgl-project:mainfrom
kvcache-ai:fix_ci_time
Oct 13, 2025
Merged

Tiny fix test run estimated time#11544
ch-wan merged 1 commit intosgl-project:mainfrom
kvcache-ai:fix_ci_time

Conversation

@ShangmingCai
Copy link
Copy Markdown
Collaborator

Motivation

Main CI is flaky again due to some PRs that added more test cases, but did not increment the estimated time:

Modifications

Accuracy Tests

Benchmarking and Profiling

Checklist

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @ShangmingCai, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request aims to enhance the stability of the continuous integration (CI) pipeline by correcting underestimated test execution times. Recent additions of test cases in certain files led to CI flakiness, as the system would time out before tests could complete. By updating the estimated run times for these specific test suites, the PR ensures that the CI environment has adequate time to process all tests, preventing premature timeouts and promoting a more reliable build process.

Highlights

  • CI Stability Improvement: Addresses continuous integration flakiness by adjusting estimated test run times for specific test files that were previously causing timeouts.
  • Test Time Adjustment: Increased the estimated run time for models/test_encoder_embedding_models.py from 100 to 460 seconds.
  • Test Time Adjustment: Increased the estimated run time for test_score_api.py from 180 to 310 seconds.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the estimated run times for two test files to fix CI flakiness, which is a good and necessary change. My review includes suggestions to add comments next to the updated times. This should help remind developers to update these values in the future, preventing similar issues. Additionally, I noticed a minor sorting issue in the per-commit-1-gpu test suite that could be addressed in a follow-up to improve code consistency, as batch_invariant/test_batch_invariant_ops.py appears to be out of alphabetical order.

@ch-wan ch-wan merged commit c5fe3c0 into sgl-project:main Oct 13, 2025
10 of 41 checks passed
lpc0220 pushed a commit to lpc0220/sglang that referenced this pull request Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants