fix(load): allow function to be exported (as docs say) #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**What**: closes #88 **Why**: Because we document that you can export a function that returns a configuration, but it doesn't actually work. **How**: Add some logic to `loadConfig` in `src/bin-utils/index.js` to handle the case when the config is a function. Also, we need to pass the input along, so I had to make a few other changes as well. Also added fixtures and tests for this.
kentcdodds
requested review from
giladgo,
gunnx,
jisaacks,
martellaj,
nkbt,
osdevisnot,
rowanoulton,
sxn and
tleunen
Codecov Report@@ Coverage Diff @@
## master #98 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 11 14 +3
Lines 260 273 +13
=====================================
+ Hits 260 273 +13
Continue to review full report at Codecov.
|
Collaborator
Author
|
Anyone wanna review this really quick? |
tleunen
approved these changes
Feb 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: closes #88
Why: Because we document that you can export a function that returns
a configuration, but it doesn't actually work.
How: Add some logic to
loadConfiginsrc/bin-utils/index.jstohandle the case when the config is a function. Also, we need to pass the
input along, so I had to make a few other changes as well. Also added
fixtures and tests for this.
This also adds @erikfox to the contributors table for reporting the bug! Thanks!