Fix: camelCase default scripts #185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #185 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 12 12
Lines 386 385 -1
Branches 93 93
=====================================
- Hits 386 385 -1
Continue to review full report at Codecov.
|
Miklet
approved these changes
Aug 17, 2018
Collaborator
Miklet
left a comment
Miklet
left a comment
There was a problem hiding this comment.
I have no questions, it looks good for me 👍
kentcdodds
approved these changes
Aug 20, 2018
Collaborator
kentcdodds
left a comment
kentcdodds
left a comment
There was a problem hiding this comment.
Sounds good. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: camelCasing for default
start:*scripts onnps initWhy: the resulting JS from
nps initcan be currently broken (see #186)How: by fixing the code & adding tests
Checklist: